Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Fix proxytimeout handling #795

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

bpradipt
Copy link
Member

@bpradipt bpradipt commented Apr 5, 2023

Also increase the default timeout to account for different environments

Fixes: #794

@bpradipt bpradipt requested review from yoheiueda and huoqifeng April 5, 2023 06:51
@yoheiueda
Copy link
Member

https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/4615746131/jobs/8159942358?pr=795#step:6:156

It looks like the v4.3.2 of retry module has a bug. We need to update it to v4.3.3 or later.
avast/retry-go#84

Also increase the default timeout to account for different
environments

Fixes: confidential-containers#794

Signed-off-by: Pradipta Banerjee <[email protected]>
Copy link
Member

@yoheiueda yoheiueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Member

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @bpradipt

@bpradipt bpradipt merged commit 608fe4a into confidential-containers:staging Apr 5, 2023
@bpradipt bpradipt deleted the fix-794 branch April 5, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxytimeout is not working as intended
3 participants