Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix laravel workflow #40

Closed
wants to merge 4 commits into from
Closed

Fix laravel workflow #40

wants to merge 4 commits into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Feb 27, 2024

  • PHP setup was later than Composer usage
  • Tests were run only on one PHP version
  • composer install needs a lock file

@szepeviktor
Copy link
Contributor Author

@iamgergo Laravel v9 runs on PHP 8.0
https://github.com/laravel/framework/blob/9.x/composer.json#L18
but we have a problem.

@szepeviktor
Copy link
Contributor Author

In Laravel v9 it is vendor:publish --tag=lang

@szepeviktor
Copy link
Contributor Author

No tests for Laravel v9?

@szepeviktor szepeviktor closed this Mar 7, 2024
@szepeviktor szepeviktor deleted the patch-1 branch March 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant