Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for osx #88

Closed
wants to merge 1 commit into from
Closed

fix support for osx #88

wants to merge 1 commit into from

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Oct 8, 2021

This PR adds the minimum amount of changes needed to make OSX applications work again. It's not the most elegant code, but let's start small.

Summary of changes:

  • Recover utils.get_executable from the original appinst
  • Fix class signatures
  • Conform to the menuinst.install(...) API expected by conda (same as windows)
  • Comply with the modern plistlib API
  • Slugify script name (last component of/Applications/${NAME}.app/Contents/MacOS/${NAME})
  • Bring some placeholders used on Windows too

@jaimergp jaimergp requested a review from a team as a code owner October 8, 2021 16:32
@jaimergp
Copy link
Contributor Author

jaimergp commented Oct 8, 2021

This will need changes in the menuinst recipe too. The current implementation requires python.app for some reason.

@hoechenberger
Copy link

I'd just like to say that it would be great to have these changes added to menuinst. If there's any way in which I could help make that happen, please do let me know.

@isuruf
Copy link
Contributor

isuruf commented Aug 11, 2022

This looks good to me. Can we enable tests for this so that we don't accidentally break this in the future?

@jezdez jezdez requested review from a team and removed request for a team August 11, 2022 14:43
@jaimergp
Copy link
Contributor Author

Thanks @isuruf! I don't know if we want to pursue this series of updates though (this PR, and the one for Linux).

There's a full rewrite on #91 that implements the same functionality with a new cross-platform schema. It could be considered a new major version, though.

Enabling non-Windows also requires changes in conda itself.

I think we should close this PR, and #89, and work our way towards cross-platform compatibility through #91.

@jaimergp jaimergp marked this pull request as draft August 12, 2022 13:34
@hoechenberger
Copy link

I think we should close this PR, and #89, and work our way towards cross-platform compatibility through #91.

I agree!

@jaimergp jaimergp closed this Jan 12, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants