Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for the CEP prototype #112

Merged
merged 25 commits into from
Feb 13, 2023
Merged

Add documentation for the CEP prototype #112

merged 25 commits into from
Feb 13, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 12, 2023 •
edited
Loading

Description

Mimics conda-libmamba-solver and constructor's setup. It rearranges the schema bits to make it easier to autodocument (from embedded classes to a flat hierarchy). slugify will also turn _ to - to make it macOS compliant.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 12, 2023
@jaimergp jaimergp mentioned this pull request Jan 12, 2023
Closed
@jaimergp jaimergp mentioned this pull request Jan 19, 2023
Closed
@jaimergp jaimergp marked this pull request as ready for review February 6, 2023 23:42
@jaimergp jaimergp requested a review from a team as a code owner February 6, 2023 23:42
@jaimergp jaimergp changed the title Add documentation for the CEP prototype (WIP) Add documentation for the CEP prototype Feb 7, 2023
@jaimergp
Copy link
Contributor Author

@goanpeca can you take another look? :D

@goanpeca
Copy link

Looking!

goanpeca
goanpeca reviewed Feb 11, 2023
View reviewed changes
docs/source/reference.md Outdated Show resolved Hide resolved
@jaimergp
Copy link
Contributor Author

Added some changes to address your comments @goanpeca. LMK how it looks!

goanpeca
goanpeca approved these changes Feb 13, 2023
View reviewed changes
Copy link

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the WIP missing, otherrwise looks awesome 🚀

@jaimergp jaimergp merged commit 5dc44bf into conda:cep-devel Feb 13, 2023
@jaimergp jaimergp mentioned this pull request Feb 13, 2023
Closed
@jaimergp jaimergp added this to the v2.0 milestone Sep 13, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goanpeca goanpeca goanpeca approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🧭 Planning
Archived in project
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jaimergp @goanpeca @conda-bot