add info/about.json #941
Merged
add info/about.json #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilanschnell
added
enhancement
and removed
in_progress
|
I'm not sure about your simplified file writing. I think it should work - and the Travis tests seem happy enough, but do you know why that was there in the first place? |
|
I have no idea why the file writing was done so complicated in the first place. |
Current coverage is 10.4%@@ master #941 diff @@
==========================================
Files 41 41
Lines 5287 5292 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 549 549
- Misses 4738 4743 +5
Partials 0 0
|
| @@ -218,13 +217,20 @@ def create_info_files(m, files, include_recipe=True): | |||
| info_index['depends'] = [' '.join(dist.rsplit('-', 2)) | |||
| for dist in dists] | |||
|
|
|||
| # Deal with Python 2 and 3's different json module type reqs | |||
| mode_dict = {'mode': 'w', 'encoding': 'utf-8'} if PY3 else {'mode': 'wb'} | |||
There was a problem hiding this comment.
I think it might be important that we keep the encoding: uft-8 part. I'm guessing it was like this to support unicode.
|
What is the status on this PR? The information in the extra file is needed by Anaconda Cloud. |
|
I am uneasy about your simplification of file writing. Please remove that from your PR, and I'm happy to merge your info.json file addition. |
This reverts commit 1f2c4d9.
|
@msarahan, here you go |
|
thanks |
kenodegard
added
type::feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add
info/about.jsonto the conda package, which contains the following keys:There are simply copied from the
aboutsection inmeta.yaml(if they exist).This addresses #939