Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open_recipe context to simplify recipe handling #5238

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 15, 2024

Description

When working with a recipe we can expect to receive a file (meta.yaml), a directory (recipe), or even a tarball (package).

When a tarball was passed we would need to keep track of this in order to close the tarball once we finish working. Using a context manager is much better suited for this kind of behavior so we propose moving all of this logic regarding how to "open" a recipe into a dedicated function.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 15, 2024
@kenodegard kenodegard marked this pull request as ready for review March 15, 2024 16:26
@kenodegard kenodegard requested a review from a team as a code owner March 15, 2024 16:26
Copy link

codspeed-hq bot commented Mar 21, 2024

CodSpeed Performance Report

Merging #5238 will not alter performance

Comparing kenodegard:_open_recipe (2ddae67) with main (127ce33)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard merged commit 51f81ce into conda:main Mar 25, 2024
28 checks passed
@kenodegard kenodegard deleted the _open_recipe branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants