fix error where an intermediate None value was breaking jinja2 for git #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
force-pushed
the
fix_jinja2_int_error
branch
from
c3c889d
to
d7fcafc
Compare
| return int(self.get_value('build/number', 0)) | ||
| number = self.get_value('build/number', 0) | ||
| # build number can come back as None if no setting (or jinja intermediate) | ||
| return int(number) if number else 0 |
There was a problem hiding this comment.
else 0 should be None here, so that build_number triggers jinja invalid messages.
msarahan
added a commit
to msarahan/conda-build
that referenced
this pull request
Jul 5, 2016
…umber_api Improvement to conda#1088. Returns None instead of 0 when no build number …
msarahan
pushed a commit
that referenced
this pull request
Jul 5, 2016
…provided to trigger Jinja2 debugging help. Alerts users when invalid string like 'abc' passed instead of integer build number
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
Thanks @elehcim for pointing this out and helping with the test case.