Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.8.12 breaks hardcoded PREFIX detection in Windows #3899

Closed
jaimergp opened this issue Mar 9, 2020 · 2 comments
Closed

3.8.12 breaks hardcoded PREFIX detection in Windows #3899

jaimergp opened this issue Mar 9, 2020 · 2 comments
Labels
locked [bot] locked due to inactivity

Comments

@jaimergp
Copy link
Contributor

jaimergp commented Mar 9, 2020

Actual Behavior

After upgrading to conda-build=3.18.12, Windows nightly builds for openmm in omnia-md/conda-dev-recipes do no longer work. The issue has to do with a hardcoded PREFIX occurrence in a Python file inside the package, which should be patched by conda-build. v3.8.11 works correctly.

Last successful build (conda-build 3.8.11):

Detected hard-coded path in text file Lib/site-packages/simtk/openmm/version.py

Failing builds

INFO :: Time taken to mark (prefix)
        0 replacements in 0 files was 0.41 seconds

Expected Behavior

conda-build=3.8.12 should detect Lib/site-packages/simtk/openmm/version.py has a hardcoded path that needs to be replaced.

Steps to Reproduce

Windows only:

git clone https://github.com/omnia-md/conda-dev-recipes
cd conda-dev-recipes
git checkout debug-variants
conda install conda-build=3.8.12
conda build openmm
Output of conda info

Not available right now, but full logs can be checked here.

mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Mar 13, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Mar 13, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Mar 13, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Mar 13, 2020
mingwandroid added a commit to mingwandroid/conda-build that referenced this issue Mar 13, 2020
@jaimergp
Copy link
Contributor Author

Thanks!

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Hi there, thank you for your contribution!

This issue has been automatically locked because it has not had recent activity after being closed.

Please open a new issue if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

No branches or pull requests

1 participant