-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEP for the OCI storage of conda packages & repodata #70
Open
wolfv
wants to merge
13
commits into
conda:main
Choose a base branch
from
wolfv:oci-cep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
438598e
OCI cep
wolfv 5e3daed
Update cep-oci.md
wolfv ea109b7
Update cep-oci.md
wolfv 0416a33
Update cep-oci.md
wolfv e8f19c1
add some details for the oci <-> conda mapping
wolfv 9bb27ea
add some more info
wolfv 6ee85fa
Update note formatting and add link
wolfv d339ca0
Add more info (mediaTypes, implementation...)
Hind-M c32ccd2
Merge pull request #3 from Hind-M/oci-cep
wolfv 8cdc5f2
Comply with ceps template
Hind-M 5c88967
Remove mentioning mirrors
Hind-M 193259a
Review:
Hind-M 6e6cd7d
Add important note regarding the mapping of package names and tags
Hind-M File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we marking these as mirrored instead making them first-class things via using the normal channels config setting with an
oci://
prefix to mark OCI channels?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is orthogonal - you should be able to use the
oci://
URL as your only channel as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why do we need the
mirrored_channels
option at all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not in this CEP? Specifying how we expect channel mirroring works could have merits. Specifically, we should define where the
repodata.json
file comes from when we have multiple mirrors.Ideally we would also define how we combine download counts from multiple mirrors (but all that would definitely belong into a different CEP).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we should handle mirroring in another CEP I would think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's orthogonal. I changed it to not mention mirrors anymore.