Add read-file action
#203
Merged
Add read-file action
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jezdez
previously approved these changes
Aug 27, 2024
kenodegard
force-pushed
the
read-file
branch
from
3081552 to
719ff88
Compare
Merged
kenodegard
commented
Jan 9, 2025
kenodegard
commented
Jan 10, 2025
kenodegard
commented
Jan 10, 2025
jezdez
approved these changes
Jan 24, 2025
Comment on lines
+84
to
+85
| assert '''${{ steps.json.outputs.content }}''' == '''${{ steps.yaml.outputs.content }}''' | ||
| assert '''${{ fromJSON(steps.json.outputs.content)['foo'] }}''' == '''${{ fromJSON(steps.yaml.outputs.content)['foo'] }}''' |
There was a problem hiding this comment.
Any reason to use triple single quotes here and not single double quotes?
There was a problem hiding this comment.
Because the json values might contain quotes at some point in the future 🤷🏼♂️
| Run a test server on a random port. Inspect returned server to get port, | ||
| shutdown etc. | ||
|
|
||
| See https://github.com/conda/conda/blob/52b6393d6331e8aa36b2e23ab65766a980f381d2/tests/http_test_server.py |
There was a problem hiding this comment.
Have we copied this fixture enough around that it would be useful to have it on PyPI as a pytest extension?
There was a problem hiding this comment.
AFAIK this is only the second place and idk how much we'd benefit from standardizing this further, this has deviated quite a bit from what was copied
There was a problem hiding this comment.
I miss remembered, this fixture is almost identical to the one in conda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #243
Adding a
read-fileaction that will support reading a local or remote file and supports both JSON and Yaml but will also allow leaving the output as a plain string.This action replaces
read-yaml.