Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to catch EnvironmentSectionNotValid #94

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Nov 16, 2020

Fixes #93

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jaimergp

Thanks for looking into this!

How did you test it? We will need to add actual unit tests to this. (for a separate PR, no worries)

Any suggestions @bollwyvl ?

@jaimergp
Copy link
Member Author

I didn't and I don't know how to do it locally 😬 I can add the tests in this PR too, but I'll need some guidance. Where should I look?

@goanpeca
Copy link
Member

I didn't and I don't know how to do it locally

No worries I will setup something to get some basic testing setup for this locally.

In the meantime maybe just create a new workflow that falis https://github.com/conda-incubator/setup-miniconda/blob/master/.github/workflows/example-1.yml if it fails then we are good :-p

@goanpeca
Copy link
Member

@jaimergp for (github CI) security reasons, I think the new workflow will not run so I will merge, and please check again what happens on the actions that will run on master and open a new PR accordingly :-p

Thanks again!

@goanpeca goanpeca merged commit 3a687cc into conda-incubator:master Nov 16, 2020
@goanpeca
Copy link
Member

@jaimergp
Copy link
Member Author

Nop, it was a syntax error. I'll open a new one.

@jaimergp jaimergp mentioned this pull request Nov 16, 2020
jaimergp added a commit to jaimergp/setup-miniconda that referenced this pull request Nov 17, 2020
goanpeca added a commit that referenced this pull request Nov 18, 2020
@goanpeca goanpeca added this to the v2.0.1 milestone Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent errors with faulty environment file
2 participants