-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda-solver option #291
Conversation
@@ -14,9 +14,6 @@ export const updateMamba: types.IToolProvider = { | |||
provides: async (inputs, options) => | |||
inputs.mambaVersion !== "" || options.mambaInInstaller, | |||
toolPackages: async (inputs, options) => { | |||
core.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So mamba support is no longer experimental?
Should we still warn about "differently solved environments!" @jaimergp ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I'd expect people to know enough about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaimergp just to double check, are the options being automatically used with the solver, or do we need to update the code to actually include the use of such option? 🤔
|
Any update on this one here? Would be nice to be able to use the new conda solver! |
Hi @tobiasdiez, in the meantime, you can use - uses: conda-incubator/setup-miniconda@v2
env:
CONDA_SOLVER: libmamba
with:
auto-update-conda: true
python-version: "3.9" |
@jaimergp is the failing test related to this change? 🤔 |
@goanpeca - not our fault. Both
That test should be expected to fail. Maybe old versions supported that, but not anymore. So either a bug to report or something not supported anymore, but nothing we need to do on our side to handle it (other than xfail/remove the test). |
Done |
libmamba is the default solver for conda since version 23.10.0 and miniconda3 23.10.0 ... so the new standard / reality is lib/mamba and users get used to it... do we still want this option to be able to switch to the old solver OR should we skip the option for the sake of less configuration hell and test-combination explosion?... users can also switch to the old solver by requesting an old miniconda3. @jaimergp The PR looks good and is all green. Do you still want it? Merge or close it? |
Github Actions runners now ship Miniconda 23.5.2, which bundles conda-libmamba-solver (although it's not enabled by default).
conda
will switch tolibmamba
as the new default solver soon, so we better be prepared and provide configurability here to (A) opt-in already, (B) opt-out if it doesn't work.