Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Miniforge inputs #138

Merged
merged 5 commits into from
Dec 31, 2020
Merged

Rework Miniforge inputs #138

merged 5 commits into from
Dec 31, 2020

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl changed the title Rework Miniforge inputs [wip] Rework Miniforge inputs Dec 31, 2020
@goanpeca
Copy link
Member

Is this ready for review @bollwyvl ?

goanpeca
goanpeca reviewed Dec 31, 2020
View reviewed changes
action.yml
@@ -20,7 +20,7 @@ inputs:
description:
"If provided, this variant of Miniforge will be downloaded and installed.
Currently-known values:
- Miniforge3
- Miniforge3 (default)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bollwyvl we should add the default here no?

    required: false
    default: "Miniforge3"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll take a look...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

510ef46 and 6689c3c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6689c3c points out that we still have some incidental coupling between the various inputs... it still seems manageable, but i wish i could think of a way to simply express these constraints more declaratively... adding something like JSON schema could do, but more deps...

goanpeca
goanpeca requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the action yaml needs a small fix.

Otherwise LGTM :)

@bollwyvl bollwyvl changed the title [wip] Rework Miniforge inputs Rework Miniforge inputs Dec 31, 2020
goanpeca
goanpeca approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot @bollwyvl 🥳 !

@goanpeca goanpeca merged commit f2eab79 into conda-incubator:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goanpeca goanpeca goanpeca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @goanpeca