Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8 0f #107] move base env tool providers to dedicated files #130

Merged
merged 6 commits into from
Dec 24, 2020
Merged

[8 0f #107] move base env tool providers to dedicated files #130

merged 6 commits into from
Dec 24, 2020

Conversation

bollwyvl
Copy link
Contributor

This moves extra tools for the base env into dedicated files, and finally reduces setup.ts to right at 100 lines.

This is the end of what #107 had implemented, and no additional changes are planned at this scale 🎉

Thanks @goanpeca for the review

goanpeca
goanpeca reviewed Dec 24, 2020
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
goanpeca
goanpeca reviewed Dec 24, 2020
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
goanpeca
goanpeca reviewed Dec 24, 2020
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
goanpeca
goanpeca reviewed Dec 24, 2020
View reviewed changes
src/types.ts
/**
* Steps to peform after the env is updated, and potentially reconfigured
*/
postInstall?: (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha nothing :)

goanpeca
goanpeca reviewed Dec 24, 2020
View reviewed changes
src/base-tools/index.ts Outdated Show resolved Hide resolved
goanpeca
goanpeca approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bollwyvl for the awesome refactoring work!

LGTM :)

@bollwyvl
Copy link
Contributor Author

@goanpeca thanks for the quick review... think i hit all the points raised above...

@bollwyvl bollwyvl changed the title [wip] [8 0f #107] move base env tool providers to dedicated files [8 0f #107] move base env tool providers to dedicated files Dec 24, 2020
@bollwyvl bollwyvl marked this pull request as ready for review December 24, 2020 18:34
@bollwyvl
Copy link
Contributor Author

Not _quite_ready...


Thu, 24 Dec 2020 18:30:26 GMT   
Thu, 24 Dec 2020 18:30:26 GMT   Currently, only install, create, list, search, run, info and clean are supported through mamba.
Thu, 24 Dec 2020 18:30:26 GMT   Creating bash wrapper for `mamba`...
Thu, 24 Dec 2020 18:30:26 GMT   ... wrote C:/Miniconda\condabin\mamba.bat:
Thu, 24 Dec 2020 18:30:26 GMT   bash.exe -c "exec 'C:/Miniconda\condabin\mamba.bat' $*"

I want those slashes to be consistent...

@bollwyvl
Copy link
Contributor Author

Looks better:

   Creating bash wrapper for `mamba`...
  ... wrote C:/Miniconda/condabin/mamba.bat:
  bash.exe -c "exec 'C:/Miniconda/condabin/mamba.bat' $*" || exit 1

@bollwyvl
Copy link
Contributor Author

Ok, I think the log output is good now... added a final output, just so there's a timestamp outside the group.

@goanpeca goanpeca merged commit 5fa1d1a into conda-incubator:master Dec 24, 2020
@goanpeca goanpeca added this to the v2.1.0 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goanpeca goanpeca goanpeca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @goanpeca