Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH - Use miniforge throughout #634

Merged
merged 4 commits into from
Oct 18, 2023
Merged

ENH - Use miniforge throughout #634

merged 4 commits into from
Oct 18, 2023

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Oct 18, 2023

Fixes #632
Fixes #630

Description

  • This should fix the flaky CI errors - it ensures we do not mix defaults and conda-forge, so we use miniforge to set all the environments.
  • Added some quick fixes to the env files to silence the pip-related warnings and ensure defaults are not used (I changed the microsoft channel capitalisation, and that might fix [BUG] - Make docker-compose and playwright optional on ARM64 #630, though I could not reproduce locally 🤷🏽‍♀️ so I am not sure that is the root cause)

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@trallard trallard added the area: dependencies 📦 Issues related to conda-store dependencies label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d ready!

Name Link
🔨 Latest commit e0bc64c
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/652febe64bab870008aaad51
😎 Deploy Preview https://deploy-preview-634--kaleidoscopic-dango-0cf31d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trallard I've left some comments, but I think those are non-blockers and can be addressed later. Feel free to merge. We can fix up issues later if there are any.

@nkaretnikov nkaretnikov mentioned this pull request Oct 18, 2023
3 tasks
@trallard trallard merged commit dfcc49c into main Oct 18, 2023
11 checks passed
@trallard trallard deleted the trallard/actions-patch branch October 18, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
3 participants