-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 343: add conda_default_allow_channels option #356
Conversation
If set, automatically add new channels to the channels database.
The new option is set to "True" by default which breaks previous behavior. |
@costrouc I think this is more or less ready, however I think we should at least consider whether maybe instead of adding an additional option, setting the I also could use some guidance on the test implementation. |
Manually tested with: channels:
- conda-forge
- bioconda
- defaults
dependencies:
- _libgcc_mutex=0.1
- _openmp_mutex=4.5
- bcftools=1.10.2
- blis=0.7.0
- pip:
- nothing
- ipykernel
name: map-and-call
prefix: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw some Black formatting issues and just added two comments on a conditional check that needs to be made. Otherwise this PR looks great to me. Thanks for your work @csadorf
If conda_default_allow_channels is not set.
@costrouc I'd suggest that you consider my suggestion concerning the overloading of the |
Thanks @csadorf. Yeah I get what you are saying and that makes sense. I think it would be a good idea to write it like that especially since there is no case where you would want an empty list of channels in the first place. Making it so that we can overload that behavior! Would you mind making that change? Sorry for the late response |
If set, automatically add new channels to the channels database.
Before merge:
Closes #343.