Include flask templates in built package #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, trying to access /home results in a template not found error
Co-authored-by: Erik Sundell <[email protected]>
|
Thanks @yuvipanda! I'll check out this PR on Monday. I appreciate you checking out conda store and I'll comment on the hackmd you wrote as well. |
|
Thanks @costrouc! Looking forward to it :) |
2 tasks
costrouc
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Thanks @yuvipanda and @consideRatio! FYI I'm going to be adding to https://conda-store.readthedocs.io/en/latest/installation.html#local-automated-systemd-install to have a way to install this in non-containerized environments that will do a pypi based install.
I'll cut a new release to that the flask templates show up on pypi.
|
Thanks a lot, @costrouc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, trying to access /home results in a
template not found error