re-add output coupling #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2022.08.11.15.16.27
|
Without the run-dep, there are no headers, which would be an issue for the static lib... |
h-vetinari
requested review from
hmaarrfk,
msarahan,
rmax and
xhochy
as code owners
hmaarrfk
reviewed
Aug 12, 2022
| # zstd-static contains the shared libs already anyway | ||
| - zstd <0.0a0 | ||
| host: | ||
| - {{ pin_subpackage('zstd', exact=True) }} |
There was a problem hiding this comment.
Why don't you need xz and lz4-c
There was a problem hiding this comment.
Why should it need that? Also didn't exist before #62...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #62 & discussion in conda-forge/conda-forge.github.io#1809