Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #61

Conversation

conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #58.

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits July 30, 2022 10:33
@h-vetinari
Copy link
Member

Thanks for tackling this. I was thinking about it when I looked at #58, but I think this is currently not compatible with the way that zstd_static (as an output) depends on the shared zstd, because now the cmake files will clobber each other.

However, I don't see why those outputs have to be chained together like that, so it's probably fine to remove

@h-vetinari
Copy link
Member

I also wanted to look up the cmake invocation necessary to test this in the recipe...

@hmaarrfk
Copy link
Contributor

Ultimately, you will want to split the development files.

Honestly, I'm not so sure why we would jump through these hoops for this package as a static package.

I would likely just remove it. But i haven't investigated if it is used at all

@h-vetinari
Copy link
Member

No idea either why a static build might be needed, but I assumed it got added for a reason, so starting point would have been to keep it, but I wouldn't mind if it gets removed (assuming it's not a hard requirement somewhere).

Ultimately, you will want to split the development files.

Not sure I understand what you mean here - could you explain?

@h-vetinari h-vetinari mentioned this pull request Jul 31, 2022
@hmaarrfk hmaarrfk closed this in #62 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants