Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools dependency #53

Merged
merged 2 commits into from
Dec 15, 2019
Merged

Add setuptools dependency #53

merged 2 commits into from
Dec 15, 2019

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Dec 14, 2019

A build of one of my packages, which depends on xarray, failed because setuptools doesn't get installed alongside xarray, yet xarray depends on setuptools. On the conda-forge gitter channel it was then suggested that the xarray recipe should explicitly list setuptools as a run dependency. This is what this PR does.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hoechenberger
Copy link
Member Author

@conda-forge-admin, please rerender

hoechenberger added a commit to regro-cf-autotick-bot/questplus-feedstock that referenced this pull request Dec 15, 2019
@hoechenberger
Copy link
Member Author

@shoyer Same should probably also be fixed upstream :) (INSTALL_REQUIRES in setup.py)

@ocefpaf
Copy link
Member

ocefpaf commented Dec 15, 2019

Looks like the new HTML printing uses pkg_resources.

@ocefpaf ocefpaf merged commit 4a8c7aa into conda-forge:master Dec 15, 2019
@hoechenberger hoechenberger deleted the deps branch December 15, 2019 14:27
@hoechenberger
Copy link
Member Author

Thanks @ocefpaf!

@shoyer
Copy link
Contributor

shoyer commented Dec 16, 2019

Thanks for the fix. Could you kindly open an issue in the xarray issue tracker? A pull request would be even better :)

@crusaderky
Copy link

setuptools is not a runtime dependency since pydata/xarray#3720
Also, I'm confused - both conda and cpython always come with setuptools preinstalled. How did you manage to get an environment without it?

@crusaderky
Copy link

(please revert)

@hoechenberger
Copy link
Member Author

hoechenberger commented Jan 30, 2020

@crusaderky setuptools at least doesn't get automatically installed on the conda-forge CI when the tests are run. I've created a PR that uses an xarray package version that doesn't have the setuptools dep, and the build fails: conda-forge/questplus-feedstock#10
This is why setuptools was added as a runtime dep. (This was suggested to me on the conda-forge gitter channel)

@crusaderky
Copy link

Ah I see now that it's required by xarray.core.formatting_html too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants