-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setuptools dependency #53
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2019.12.02
Until conda-forge/xarray-feedstock#53 is resolved
@shoyer Same should probably also be fixed upstream :) ( |
Looks like the new HTML printing uses pkg_resources. |
Thanks @ocefpaf! |
Thanks for the fix. Could you kindly open an issue in the xarray issue tracker? A pull request would be even better :) |
setuptools is not a runtime dependency since pydata/xarray#3720 |
(please revert) |
@crusaderky |
Ah I see now that it's required by xarray.core.formatting_html too. |
A build of one of my packages, which depends on
xarray
, failed becausesetuptools
doesn't get installed alongsidexarray
, yetxarray
depends onsetuptools
. On the conda-forge gitter channel it was then suggested that thexarray
recipe should explicitly listsetuptools
as a run dependency. This is what this PR does.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)