Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild for CUDA 12 w/arch support #15

Merged
merged 15 commits into from
Dec 5, 2023
Merged

Rebuild for CUDA 12 w/arch support #15

merged 15 commits into from
Dec 5, 2023

Conversation

RaulPPelaez
Copy link
Contributor

@RaulPPelaez RaulPPelaez commented Nov 13, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #13
Closes #16

regro-cf-autotick-bot and others added 3 commits November 9, 2023 08:46
@regro-cf-autotick-bot
Rebuild for CUDA 12 w/arch support
08f4bed 
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@regro-cf-autotick-bot
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.28.0, and co…
c10d064 
…nda-forge-pinning 2023.11.08.21.35.56
@RaulPPelaez
Update for CUDA 12
bfadf84
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@RaulPPelaez
Copy link
Contributor Author

@erip @h-vetinari please review

@RaulPPelaez RaulPPelaez mentioned this pull request Nov 16, 2023
Closed
jakirkham
jakirkham reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raul! 🙏

Had one question below

.ci_support/migrations/cuda120.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Thanks Raul! 🙏

Looks like it is passing 🎉

@conda-forge/triton , could you please take a look? 🙂

jakirkham
jakirkham reviewed Nov 28, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@RaulPPelaez @jakirkham
Update recipe/meta.yaml
72a8b92 
Co-authored-by: jakirkham <[email protected]>
@jakirkham jakirkham mentioned this pull request Nov 29, 2023
Closed
@jakirkham
Copy link
Member

Anything else needed here?

h-vetinari
h-vetinari approved these changes Nov 29, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
jakirkham
jakirkham reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raul & Axel! 🙏

Think we can actually simplify meta.yaml a bit. Have made some notes below

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
RaulPPelaez and others added 3 commits November 29, 2023 07:53
@RaulPPelaez @jakirkham
Update recipe/meta.yaml
cfe6f5c 
Co-authored-by: jakirkham <[email protected]>
@RaulPPelaez @jakirkham
Update recipe/meta.yaml
b351b00 
Co-authored-by: jakirkham <[email protected]>
@RaulPPelaez @jakirkham
Update recipe/meta.yaml
aae976d 
Co-authored-by: jakirkham <[email protected]>
@RaulPPelaez
Copy link
Contributor Author

@conda-forge-admin, please rerender

@RaulPPelaez
Copy link
Contributor Author

Thanks for the good advice guys!

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/triton-feedstock/actions/runs/7029074042.

jakirkham
jakirkham reviewed Nov 29, 2023
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Thanks Raul! 🙏

Pushed a couple cosmetic changes to your PR (hope that is ok)

This looks pretty good 👍

@RaulPPelaez
Copy link
Contributor Author

Maybe we can go ahead and mix #16 in here too?

@jakirkham
Copy link
Member

If you like

Though think you have already captured the important pieces (and added to them). So this should already be good

@jakirkham jakirkham mentioned this pull request Nov 29, 2023
Closed
@RaulPPelaez
Copy link
Contributor Author

I merged them locally but the only difference is the build number, so I think it should be ok to close #16 ?

@jakirkham
Copy link
Member

The migration bot treats closed migration PRs as completed (IOW the same as if they were merged)

We could add a "Closes #x" to the OP in this PR and it would close that one out when this one merges

@RaulPPelaez
Copy link
Contributor Author

Done! so much bot magic going on under the hood!

@jakirkham
Copy link
Member

Thanks Raul! 🙏

@h-vetinari does this look better?

@h-vetinari h-vetinari changed the title Rebuild cuda120 0 2 hc868d4 Rebuild for CUDA 12 w/arch support Nov 29, 2023
h-vetinari
h-vetinari approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looking good from my side, thanks for iterating (I like that the changes to the recipe itself are minimal, almost non-existent)! I'd still suggest to increment the build number, but not a requirement.

recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Agreed. Good call. Thanks Axel! 🙏

Think we are good to merge at this point

@RaulPPelaez
Copy link
Contributor Author

@jakirkham @h-vetinari could you merge? Thanks!

@h-vetinari h-vetinari merged commit 7a481ee into conda-forge:main Dec 5, 2023
13 checks passed
@jakirkham
Copy link
Member

Thanks Raul and Axel! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@h-vetinari h-vetinari h-vetinari approved these changes

@erip erip Awaiting requested review from erip erip is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaulPPelaez @jakirkham @h-vetinari @regro-cf-autotick-bot