Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libabseil20240722_grpc165_libprotobuf5275 #403

Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Oct 11, 2024

Fixes #404

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! I guess we mainly need someone to build osx? Also pinging @hmaarrfk @ngam if you can help by any chance.

recipe/meta.yaml Outdated Show resolved Hide resolved
@xhochy
Copy link
Member Author

xhochy commented Oct 12, 2024

It's a grey cold day here. I can do the rebuild and heat my house 🧣

Co-authored-by: h-vetinari <[email protected]>
@h-vetinari
Copy link
Member

It's a grey cold day here. I can do the rebuild and heat my house 🧣

That's amazing! 😊

Could you just delete the second over-complicated protobuf-pin as well? I just commented in one place and thought the extension was obvious 😅

@xhochy
Copy link
Member Author

xhochy commented Oct 12, 2024

Could you just delete the second over-complicated protobuf-pin as well? I just commented in one place and thought the extension was obvious 😅

Sorry, was on mobile again 🙈

@xhochy
Copy link
Member Author

xhochy commented Oct 16, 2024

osx-64-logs.zip

@xhochy
Copy link
Member Author

xhochy commented Oct 16, 2024

osx-arm64-logs.zip

@xhochy xhochy merged commit a42224a into conda-forge:main Oct 16, 2024
11 of 20 checks passed
@xhochy xhochy deleted the libabseil20240722_grpc165_libprotobuf5275 branch October 16, 2024 05:33
@h-vetinari
Copy link
Member

Thank you very much! 🙏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants