-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow v2.14.0 #347
tensorflow v2.14.0 #347
Conversation
…nda-forge-pinning 2023.10.23.08.51.53
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@xhochy As conda-forge/keras-feedstock#68 is merged now - is there anything missing for this PR to be merged? |
@conda-forge-admin, please restart ci |
Please don't do this on the repo. CI is disabled anyways. |
Yes, a successful build. I have a set of five patches locally that I need to push but they are not exhaustive to get it even passing without CUDA. |
4437b6d
to
e25c344
Compare
…nda-forge-pinning 2023.11.08.21.35.56
CPU builds are passing, CUDA still has issues which could also relate to my available RAM. |
Ok i'll try one, i have a 128GB machine availble. |
@hmaarrfk I can also do it. My machine is a cloud instance and I can just switch it to a larger one. |
The CUDA 11.8 build passed. I will retry the 11.2 with more RAM. In general, this PR is ready for review. I will build out all variants over the weekend. |
is Python 3.12 compatibility a thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -1 +1,3 @@ | |||
tar -C ${PREFIX} -xf $SRC_DIR/libtensorflow_cc_output.tar | |||
mkdir -p ${PREFIX}/include/tensorflow/tsl/platform/include | |||
cp float8.h ${PREFIX}/include/tensorflow/tsl/platform/include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid this workaround? Non-blocker, but kind of surprising...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its somewhat strange because ml_dtypes is a python package. we could repackage ml_dtypes as a library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in general a very strange interaction as Tensorflow also builds "a" ml_dtypes as a library internally again. I would rather move forward with this hack and hope that in 2.15 things are cleared up a bit more instead of trying to split the ml_dtypes
package into pieces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do they vendor the library? it seems scary to pin so hard on ml_dtypes 0.2.0
- six >=1.12 | ||
- termcolor >=1.1.0 | ||
- typing_extensions >=3.6.6,<4.6.0 | ||
- wrapt >=1.11.0 | ||
- typing_extensions >=3.6.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Not yet. |
…nda-forge-pinning 2023.11.09.13.45.39
It seems like we need to wait for 2.16. 3.12 support is not included in the 2.15 release candidate. |
In addition, https://conda-forge.org/status/ reports a conflict with protobuf, which might need to be resolved.
|
Compilation breaks for CUDA 11.2 with
As we are dropping CUDA 11.2 with a lot of other packages, I will do the same here. |
…nda-forge-pinning 2023.11.09.20.47.34
Makes sense 11.8 supports the same hardware |
I feel like updating tensorflow, and updating protobuf with tensorflow can be considered two different steps. I don't think we should necessarily hold up this progress. It isn't ideal, but we need to continue to ask upstream to make it easier to plug in "system" dependencies. |
|
amazing work! |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6613951688, please use this URL for debugging.