-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidyjson recipe file #8619
tidyjson recipe file #8619
Conversation
sbilge
commented
Jun 24, 2019
- License file is packaged (see here for an example)
- Source is from official source
- Package does not vend other packages
- Build number is 0
- GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core @conda-forge/help-r @conda-forge/staged-recipes Would you please review my code? Tests are failing but I am not sure why. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@sbilge Thanks for contributing this recipe! The tests are failing because you have not included the build scripts that accompany the metadata file:
https://ci.appveyor.com/project/conda-forge/staged-recipes/builds/25498077#L485 To make the submission process go as smoothly as possible, could you please use the conda-forge helper script for R recipes? You can read about this and other contributing instructions in the documentation on contributing packages. A few notes:
|
@jdblischak Thank you very much! |
@sbilge Please let me know once you've updated the recipe using the helper script. The helper script will make the recipe |
The package was removed from cran. That means using the r_skeleton_helper is maybe not that straight forward. |
@dbast Good point! I'll make my comments line-by-line |
|
||
source: | ||
|
||
url: https://github.com/sbilge/tidyjson/archive/v0.2.2.3.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not great. This is your personal fork of the repository.
What is the status of this package? Is colearendt the new maintainer? While a CRAN release is the best case scenario, at minimum it would be ideal if the maintainer tagged a release on the offical GitHub repository. I see you started the discussion in colearendt/tidyjson#111
Have you confirmed that you need version 0.2.2.3? In other words, would 0.2.2 be sufficent?
Also, have you considered creating a conda package and uploading it to your personal channel on Anaconda Cloud? If this R package is not well-supported, it isn't a good fit for conda-forge (because it will be hard for us to maintain it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, colearendt is the maintainer. I reached him via his email and requested a GitHub release. He said he will make the release but he did not, yet. I have to continue working on my PhD project, so I decided to use my own fork until his release. 0.2.2 is a very old version (from 2015), it would not be sufficient unfortunately.
Would it be alright if we continue with my fork for now and I update the recipe once colearendt release it? Otherwise I can try Anaconda personal channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbilge My preference would be for you to create a personal conda package until the maintainer releases a new version (preferably to CRAN, but at minimum a GitHub tag).
@conda-forge/r Any opinions on maintaining this recipe? I know I'm always the curmudgeon about maintaining non-CRAN packages...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the given URL is neither CRAN nor any upstream supported release URL (sometimes forks become the new upstream, but the commit history does not indicate that). So I don't think you are the curmudgeon here ;)
@sbilge you can upload the package to your own anaconda.org channel, the steps are something like:
- create an anaconda.org account (free)
- create an upload $token inside that account
- install
conda-build + anaconda-client
- build+upload via
conda-build staged-recipes/recipes/r-tidyjson --token $token
- Install/use the package via:
conda install -c $yourChannel r-tidyjson
orconda install $yourChannel:r-tidyjson
or add it to your environment.yml.
That should not take that long... Would that be sufficient?
This PR can be updated and merged after upstream did tag a new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbast @jdblischak Thank you. I will do so. Should I close the pull request till I update the PR with the original release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbilge Yes, please close it for now so that we know that it is not in need of our attention. You can reopen it once it's been updated for the new release. Thanks!