-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Meson #5341
Adds Meson #5341
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/meta.yaml
Outdated
|
||
build: | ||
number: 0 | ||
script: python setup.py install --single-version-externally-managed --record record.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should use python -m pip install --no-deps --ignore-installed
nowadays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I'll change that. What is the advantage of it? pip install
goes through setup.py install
, too and is more likely to crash if something is missing or am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here: conda-forge/conda-forge.github.io#518
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dirmeier very cool!
@bgruening Cool, thanks for the quick revision. |
I might be wrong here, but as this is a pure python package I think we should do it noarch. |
correct, Meson is pure python |
@bgruening Dear Björn, can you help me out here please? Not sure how to fix this. |
Thanks for trying the noarch package. |
In the future, please create a directory called |
Meson is a modern build system for C, C++, D, Fortran, Java and Rust.
Also see issue #4365 and PR #4561