Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Meson #5341

Merged
merged 6 commits into from
Mar 10, 2018
Merged

Adds Meson #5341

merged 6 commits into from
Mar 10, 2018

Conversation

dirmeier
Copy link
Member

@dirmeier dirmeier commented Mar 8, 2018

Meson is a modern build system for C, C++, D, Fortran, Java and Rust.

Also see issue #4365 and PR #4561

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • The "test" section was expected to be a dictionary, but got a CommentedSeq.
  • The recipe must have some tests.
  • The "test" section was expected to be a dictionary, but got a CommentedSeq.

@dirmeier
Copy link
Member Author

dirmeier commented Mar 8, 2018

@SoapZA

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes) and found it was in an excellent condition.


build:
number: 0
script: python setup.py install --single-version-externally-managed --record record.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should use python -m pip install --no-deps --ignore-installed nowadays.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I'll change that. What is the advantage of it? pip install goes through setup.py install, too and is more likely to crash if something is missing or am I wrong?

Copy link
Contributor

@bgruening bgruening Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirmeier very cool!

@dirmeier
Copy link
Member Author

@bgruening Cool, thanks for the quick revision.

@bgruening
Copy link
Contributor

I might be wrong here, but as this is a pure python package I think we should do it noarch.

@SoapZA
Copy link
Contributor

SoapZA commented Mar 10, 2018

correct, Meson is pure python
I would maybe consider adding ninja as a run-time dependency, in order not to pull it in for every meson-dependent package.

@dirmeier
Copy link
Member Author

dirmeier commented Mar 10, 2018

@bgruening Dear Björn, can you help me out here please? Not sure how to fix this.
Similar issue: conda/conda-build#2575

@bgruening bgruening merged commit 0c725a2 into conda-forge:master Mar 10, 2018
@bgruening
Copy link
Contributor

Thanks for trying the noarch package.

@jakirkham
Copy link
Member

In the future, please create a directory called meson (or whatever the package name is) and place your recipe in there. Fixing this with PR ( #5379 ).

This was referenced Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants