feat: Add plothist #27414
feat: Add plothist #27414
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/plothist/meta.yaml:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/plothist/meta.yaml:
|
| # Needed for install_latin_modern_fonts | ||
| - wget | ||
| - unzip |
There was a problem hiding this comment.
c.f. cyrraz/plothist#175
There was a problem hiding this comment.
Should we wait for cyrraz/plothist#176 to be merged and a new small release? Or is it ok to be merged now?
There was a problem hiding this comment.
Conda-forge will create new release PRs automatically on the conda-forge/plothist-feedstock that will be created once this is merged, so no real need here to wait now. You can just remove those dependencies in the following conda-forge release PR.
There was a problem hiding this comment.
I am not familiar with the workflow of conda-forge. We created the new release https://github.com/cyrraz/plothist/releases/tag/v1.2.6, but not PR got automatically created in https://github.com/conda-forge/plothist-feedstock. Should I do what the readme says (fork + PR) or did we miss a setup that would automatically create the PR?
There was a problem hiding this comment.
Once it is on PyPI a PR should get generated a few hours later. It takes some time for the checking scripts to loop through, but there will be a PR open within the next 24 hours.
There was a problem hiding this comment.
Thank you, it worked perfectly conda-forge/plothist-feedstock#1 😄
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
* c.f. https://github.com/cyrraz/plothist * Recipe generated with grayskull via 'grayskull pypi plothist' and then edited to add additional information. * Add wget and unzip as 'run' requirements.
matthewfeickert
force-pushed
the
feat/add-plothit
branch
from
95102fc to
09f7c6d
Compare
| build: | ||
| entry_points: | ||
| - install_latin_modern_fonts = plothist.scripts.install_latin_modern_fonts:install_latin_modern_fonts | ||
| noarch: python |
There was a problem hiding this comment.
Failing on Windows for noarch Python projects is allowed given what I've been told by conda-forge core people in the past so this is fine.
There was a problem hiding this comment.
In this particular case the package won't be installable on Windows. If that is by design, we can merge this. However, it does seem like this package can be OS-noarch. See https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-packages-with-os-specific-dependencies for more details.
There was a problem hiding this comment.
@ocefpaf In that case, given #27414 (comment) maybe we can wait for @0ctagon to make a patch release with cyrraz/plothist#176 merged and then we can have that patch release be the one that generates the feedstock (so we'd update the version and sha256).
There was a problem hiding this comment.
B/c there is a patch already we can:
- ignore that, merge it, and you'all fix it as soon as there is a new release
- backport the patch now
I don't think it is worth making it OS-noarch b/c the fix is there already.
There was a problem hiding this comment.
ignore that, merge it, and you'all fix it as soon as there is a new release
@ocefpaf I'm find with this suggestion. There should be a new patch release on PyPI before the end of the week so it would only be broken on Windows for a few days.
|
I am willing to be listed as a maintainer. |
|
@conda-forge/help-python, ready for review! |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).