Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vale-styles-* #25017

Merged
merged 30 commits into from
Apr 8, 2024
Merged

Add vale-styles-* #25017

merged 30 commits into from
Apr 8, 2024

Conversation

bollwyvl
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vale-packages) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vale-packages) and found it was in an excellent condition.

@bollwyvl bollwyvl marked this pull request as ready for review January 13, 2024 17:25
@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-python (I guess?) ready for review 📚

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, or conda-forge/help-ruby. Thanks!

@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes this is ready for review again (again) after the windows emoji upstream change.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, or conda-forge/help-ruby. Thanks!

@bollwyvl bollwyvl mentioned this pull request Jan 20, 2024
10 tasks
@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes ready for review

@bollwyvl bollwyvl force-pushed the add-vale-packages-020 branch from d4ae7be to 2a81efd Compare February 27, 2024 14:06
@bollwyvl bollwyvl changed the title Add vale-packages 0.2.0 Add vale-packages-* Feb 27, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vale-styles-alex, recipes/vale-styles-google, recipes/vale-styles-hugo, recipes/vale-styles-joblint, recipes/vale-styles-microsoft, recipes/vale-styles-proselint, recipes/vale-styles-readability, recipes/vale-styles-write-good) and found some lint.

Here's what I've got...

For recipes/vale-styles-alex:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-google:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-hugo:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-joblint:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-microsoft:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-proselint:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-readability:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/vale-styles-write-good:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vale-styles-alex, recipes/vale-styles-google, recipes/vale-styles-hugo, recipes/vale-styles-joblint, recipes/vale-styles-microsoft, recipes/vale-styles-proselint, recipes/vale-styles-readability, recipes/vale-styles-write-good) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-go @conda-forge/help-python ready for review

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@github-actions github-actions bot added the go label Feb 27, 2024
@bollwyvl bollwyvl changed the title Add vale-packages-* Add vale-styles-* Mar 23, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vale-styles-alex, recipes/vale-styles-google, recipes/vale-styles-joblint, recipes/vale-styles-microsoft, recipes/vale-styles-proselint, recipes/vale-styles-readability, recipes/vale-styles-write-good) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-go @conda-forge/help-python @conda-forge/core ready for review

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 8, 2024

@conda-forge/staged-recipes @conda-forge/help-go @conda-forge/help-python @conda-forge/core ready for review

Copy link
Contributor

github-actions bot commented Apr 8, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ocefpaf ocefpaf merged commit 756c24b into conda-forge:main Apr 8, 2024
5 checks passed
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 8, 2024

Thanks (here and elsewhere)!

@bollwyvl bollwyvl deleted the add-vale-packages-020 branch April 8, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants