Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding actflow package #24411

Merged
merged 27 commits into from
Nov 16, 2023
Merged

Adding actflow package #24411

merged 27 commits into from
Nov 16, 2023

Conversation

SammedAdmuthe
Copy link
Contributor

@SammedAdmuthe SammedAdmuthe commented Nov 2, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/actflow/wbplot) and found some lint.

Here's what I've got...

For recipes/actflow:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/actflow/wbplot:

  • license_file entry is missing, but is required.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes/actflow/wbplot:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/actflow/wbplot) and found some lint.

Here's what I've got...

For recipes/actflow:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/actflow/wbplot:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes/actflow/wbplot:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/wbplot) and found some lint.

Here's what I've got...

For recipes/actflow:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/actflow:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/wbplot:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/wbplot) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/actflow:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/wbplot:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@SammedAdmuthe
Copy link
Contributor Author

SammedAdmuthe commented Nov 3, 2023

@conda-forge-admin, please ping conda-forge/help-python
Recipe is ready for review.
Thanks

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/wbplot) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/wbplot) and found some lint.

Here's what I've got...

For recipes/actflow:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/wbplot:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/wbplot) and found some lint.

Here's what I've got...

For recipes/actflow:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/wbplot:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/actflow, recipes/wbplot) and found it was in an excellent condition.

@SammedAdmuthe
Copy link
Contributor Author

@ocefpaf I have made suggested changes to the script. The recipe has passed all the test cases.

@SammedAdmuthe
Copy link
Contributor Author

@ocefpaf I have made suggested changes.

@SammedAdmuthe
Copy link
Contributor Author

@ocefpaf I have removed extra fields and resolved other suggestions.

@SammedAdmuthe
Copy link
Contributor Author

@ocefpaf I have updated the license!

@ocefpaf
Copy link
Member

ocefpaf commented Nov 16, 2023

@ocefpaf I have updated the license!

xref.: ColeLab/ActflowToolbox@0fdc03e

@ocefpaf ocefpaf merged commit 0ad9783 into conda-forge:main Nov 16, 2023
@mbargull
Copy link
Member

@ocefpaf I have updated the license!

xref.: ColeLab/ActflowToolbox@0fdc03e

FYI: If we want to be correct, we should build off a future release (or at least that very commit) since previous releases don't indicate usability under the changed license.
(Meaning, ideal scenario is for upstream to tag/release a new version.)

@SammedAdmuthe
Copy link
Contributor Author

@ocefpaf The build has failed for actflow - https://github.com/conda-forge/actflow-feedstock. This might be because 2 scripts were merged at once wbplot and actflow. actflow has a dependency on wbplot and I feel wbplot was not published at the time actflow build was run. Can you help me with this?

@ocefpaf
Copy link
Member

ocefpaf commented Nov 17, 2023

@ocefpaf The build has failed for actflow - https://github.com/conda-forge/actflow-feedstock. This might be because 2 scripts were merged at once wbplot and actflow. actflow has a dependency on wbplot and I feel wbplot was not published at the time actflow build was run. Can you help me with this?

Exactly. All you have to do is to restart the other build.

@SammedAdmuthe
Copy link
Contributor Author

@ocefpaf

The build has succeeded but when I try to do conda install -c conda-forge actflow. I get following error.
image

I find this weird because the package has passed all the test cases during PR but now its failing when I try to download/install it in fresh environment. Do you have any suggestions?

@ocefpaf
Copy link
Member

ocefpaf commented Nov 17, 2023

Be sure to add use a single channel and try a fresh env:

conda env create --name TMP actflow

That one worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants