-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MGIS (MFrontGenericInterfaceSupport) by tfel #23818
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mgis:
For recipes/mgis:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@conda-forge/help-python-c, ready for review! |
@conda-forge/help-c-cpp, ready for review! |
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
# Conflicts: # recipes/mgis/meta.yaml
First of all, thank you @xhochy for taking the time to review this. I really appreciate it! I believe I have implemented your comments. Let me know if there's anything else you want me to change or need some additional clarification on the review comments? Best Regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented your proposed changes and replied to your questions where applicable
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).FYI: I have received permission from the author of MGIS to create a conda-forge package. Discussion here -> thelfer/MFrontGenericInterfaceSupport#123
Note! I chose to pin the gcc compilers to v8 as the primary downstream dependency I am updating (code-aster) is sensitive to different compiler versions. I will make the pinning more flexible (maybe compile for multiple compiler versions) in the future. But for now I hope it's okay I set it as is