Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MGIS (MFrontGenericInterfaceSupport) by tfel #23818

Merged
merged 19 commits into from
Oct 24, 2023

Conversation

Krande
Copy link
Contributor

@Krande Krande commented Aug 28, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

FYI: I have received permission from the author of MGIS to create a conda-forge package. Discussion here -> thelfer/MFrontGenericInterfaceSupport#123

Note! I chose to pin the gcc compilers to v8 as the primary downstream dependency I am updating (code-aster) is sensitive to different compiler versions. I will make the pinning more flexible (maybe compile for multiple compiler versions) in the future. But for now I hope it's okay I set it as is

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mgis) and found some lint.

Here's what I've got...

For recipes/mgis:

  • There are too few lines. There should be one empty line at the end of the file.

For recipes/mgis:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mgis) and found it was in an excellent condition.

@Krande
Copy link
Contributor Author

Krande commented Aug 28, 2023

@conda-forge-admin, please rerender

@Krande
Copy link
Contributor Author

Krande commented Aug 28, 2023

@conda-forge/help-python-c, ready for review!

@Krande
Copy link
Contributor Author

Krande commented Aug 31, 2023

@conda-forge/help-c-cpp, ready for review!

recipes/mgis/build.sh Outdated Show resolved Hide resolved
recipes/mgis/build.sh Outdated Show resolved Hide resolved
recipes/mgis/cross-linux.cmake Outdated Show resolved Hide resolved
recipes/mgis/meta.yaml Outdated Show resolved Hide resolved
recipes/mgis/meta.yaml Outdated Show resolved Hide resolved
recipes/mgis/meta.yaml Outdated Show resolved Hide resolved
recipes/mgis/conda_build_config.yaml Outdated Show resolved Hide resolved
@Krande
Copy link
Contributor Author

Krande commented Oct 22, 2023

First of all, thank you @xhochy for taking the time to review this. I really appreciate it!

I believe I have implemented your comments. Let me know if there's anything else you want me to change or need some additional clarification on the review comments?

Best Regards
Kristoffer

Copy link
Contributor Author

@Krande Krande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have implemented your proposed changes and replied to your questions where applicable

recipes/mgis/meta.yaml Outdated Show resolved Hide resolved
recipes/mgis/meta.yaml Show resolved Hide resolved
@carterbox carterbox merged commit 9733978 into conda-forge:main Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants