Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add med libraries #23258

Closed
wants to merge 1 commit into from
Closed

Add med libraries #23258

wants to merge 1 commit into from

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Jul 5, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/medcoupling, recipes/medfile) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/medcoupling, recipes/medfile, recipes/salome-med, recipes/salome-medcoupling) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/salome-med, recipes/salome-medcoupling) and found it was in an excellent condition.

@jschueller jschueller force-pushed the med branch 19 times, most recently from 17686fe to 8b5f994 Compare July 7, 2023 10:00
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/salome-med, recipes/salome-medcoupling) and found some lint.

Here's what I've got...

For recipes/salome-medcoupling:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [48]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/salome-med, recipes/salome-medcoupling) and found it was in an excellent condition.

@jschueller jschueller force-pushed the med branch 3 times, most recently from b7296e3 to 31f1f98 Compare July 11, 2023 06:58
@jschueller jschueller force-pushed the med branch 5 times, most recently from c5fc771 to b3d303b Compare July 12, 2023 13:44
Copy link

stale bot commented Dec 31, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Dec 31, 2023
@jschueller jschueller force-pushed the med branch 2 times, most recently from c23e9ff to 67c24c1 Compare January 2, 2024 11:43
@stale stale bot removed the stale will be closed in 30 days label Jan 2, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/salome-med, recipes/salome-medcoupling) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/salome-medcoupling:

  • The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/salome-med, recipes/salome-medcoupling) and found it was in an excellent condition.

@jschueller
Copy link
Contributor Author

ping @conda-forge/help-c-cpp

@jschueller jschueller marked this pull request as ready for review January 2, 2024 14:44
#!/bin/sh

git clone --depth 1 -b V9_11_0 https://git.salome-platform.org/gitpub/tools/configuration.git ${SRC_DIR}/configuration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this as additional sources in the recipe.

run:
- python

test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a pip check call

@Krande
Copy link
Contributor

Krande commented Mar 14, 2024

Hey, @jschueller!

Have you seen the existing libmed feedstock https://github.com/conda-forge/libmed-feedstock which also represents the med library?

If there is something missing in the libmed feedstock (we have for example not released med v9.11 version yet, just the v9.10) we would be happy to collaborate on making improvements to libmed to fullfill your requirements.

FYI: We are also making an effort to add medcoupling (see #24378)

@jschueller
Copy link
Contributor Author

see #24378

@jschueller jschueller closed this Mar 14, 2024
@jschueller
Copy link
Contributor Author

hi, for libmed it seems my patch was way simpler than yours

@Krande
Copy link
Contributor

Krande commented Mar 14, 2024

@jschueller That's interesting! If you could create a PR for the libmed feedstock with your simplified patches we can take a look more closely on the differences there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants