-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add med libraries #23258
Add med libraries #23258
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
17686fe
to
8b5f994
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/salome-medcoupling:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
b7296e3
to
31f1f98
Compare
c5fc771
to
b3d303b
Compare
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
c23e9ff
to
67c24c1
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/salome-medcoupling:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ping @conda-forge/help-c-cpp |
#!/bin/sh | ||
|
||
git clone --depth 1 -b V9_11_0 https://git.salome-platform.org/gitpub/tools/configuration.git ${SRC_DIR}/configuration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include this as additional sources in the recipe.
run: | ||
- python | ||
|
||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a pip check call
Hey, @jschueller! Have you seen the existing If there is something missing in the FYI: We are also making an effort to add |
see #24378 |
hi, for libmed it seems my patch was way simpler than yours |
@jschueller That's interesting! If you could create a PR for the libmed feedstock with your simplified patches we can take a look more closely on the differences there? |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).