Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rapidcheck package #22528

Merged
merged 19 commits into from
May 4, 2023
Merged

Conversation

DerThorsten
Copy link
Contributor

@DerThorsten DerThorsten commented Apr 11, 2023

Atm rapidcheck does not have tagged releases nor a version, therefore I use 2023.04.13 as version as this has been the date of the commit we are using

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rapidcheck) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rapidcheck) and found some lint.

Here's what I've got...

For recipes/rapidcheck:

  • The "test" section was expected to be a dictionary, but got a CommentedSeq.
  • The recipe must have some tests.
  • The "test" section was expected to be a dictionary, but got a CommentedSeq.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rapidcheck) and found some lint.

Here's what I've got...

For recipes/rapidcheck:

  • The recipe license should not include the word "License".

For recipes/rapidcheck:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rapidcheck) and found it was in an excellent condition.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you @DerThorsten.

Are you waiting for something that prevents it from being merged?

@DerThorsten
Copy link
Contributor Author

DerThorsten commented May 4, 2023

once the CI is done we should merge this

Co-authored-by: Julien Jerphanion <[email protected]>
@DerThorsten DerThorsten marked this pull request as ready for review May 4, 2023 10:18
@SylvainCorlay SylvainCorlay merged commit d10433b into conda-forge:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants