Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range-v3 #22443

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Add range-v3 #22443

merged 5 commits into from
Apr 20, 2023

Conversation

bluescarni
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/range-v3) and found it was in an excellent condition.

@bluescarni bluescarni mentioned this pull request Mar 31, 2023
@bluescarni
Copy link
Contributor Author

@conda-forge/help-c-cpp this should now be ready for review.

range-v3 is a header-only C++ library implementing the C++20 ranges proposal for earlier versions of the language (C++14 and C++17). It has no dependencies apart from the standard library.

See also #7824 .

@bluescarni
Copy link
Contributor Author

@conda-forge/help-c-cpp could I get a review please?

recipes/range-v3/meta.yaml Outdated Show resolved Hide resolved
recipes/range-v3/bld.bat Outdated Show resolved Hide resolved
@bluescarni
Copy link
Contributor Author

@apmorton @isuruf thanks for the review, I have addressed the comments.

@bluescarni
Copy link
Contributor Author

@isuruf @apmorton do you think this is ready to be merged?

@apmorton
Copy link
Contributor

LGTM, but I'm not a maintainer here - just another user interested in having range-v3 on conda-forge.

@bluescarni
Copy link
Contributor Author

@conda-forge/help-c-cpp could this be merged please?

recipes/range-v3/bld.bat Outdated Show resolved Hide resolved
Co-authored-by: Isuru Fernando <[email protected]>
recipes/range-v3/bld.bat Outdated Show resolved Hide resolved
@bluescarni
Copy link
Contributor Author

@isuruf any idea why the build with NMake is now failing in Windows?

@isuruf
Copy link
Member

isuruf commented Apr 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants