Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hidefix #21742

Closed
wants to merge 31 commits into from
Closed

add hidefix #21742

wants to merge 31 commits into from

Conversation

gauteh
Copy link
Contributor

@gauteh gauteh commented Jan 16, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hidefix) and found it was in an excellent condition.

@gauteh
Copy link
Contributor Author

gauteh commented Jan 16, 2023

@conda-forge-admin please rerender

@gauteh
Copy link
Contributor Author

gauteh commented Jan 17, 2023

@conda-forge-admin, please ping conda-forge/staged-recipes PR ready for review!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@gauteh
Copy link
Contributor Author

gauteh commented Jan 24, 2023

@conda-forge-admin, please ping conda-forge/staged-recipes do you have the chance to take a look?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

conda-forge.yml Outdated Show resolved Hide resolved
recipes/hidefix/meta.yaml Outdated Show resolved Hide resolved
recipes/hidefix/meta.yaml Outdated Show resolved Hide resolved
recipes/hidefix/meta.yaml Outdated Show resolved Hide resolved
gauteh and others added 2 commits January 26, 2023 12:31
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hidefix) and found some lint.

Here's what I've got...

For recipes/hidefix:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [19]

@gauteh
Copy link
Contributor Author

gauteh commented Jan 27, 2023

@conda-forge-admin please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hidefix) and found it was in an excellent condition.

@gauteh gauteh requested a review from xhochy January 27, 2023 09:41
@gauteh
Copy link
Contributor Author

gauteh commented May 3, 2023

Hi, @xhochy, @conda-forge/staged-recipes this is ready for another look.

@kmuehlbauer
Copy link
Contributor

@conda-forge-admin, please rerender

@kmuehlbauer
Copy link
Contributor

@conda-forge-admin, please restart ci

gauteh and others added 3 commits August 14, 2023 10:01
@gauteh
Copy link
Contributor Author

gauteh commented Aug 14, 2023

Hi @gauteh, just stumbled on this from the xarray backend issue, and would like to help nudge this forward a bit :D

Thanks, much appreciated! The build stopped working while it was sitting in review during the spring, and I haven't had the chance to look into it during the summer. Any further ideas on how to fix it are much appreciated.

recipes/hidefix/meta.yaml Outdated Show resolved Hide resolved
gauteh and others added 2 commits August 15, 2023 13:58
recipes/hidefix/meta.yaml Outdated Show resolved Hide resolved
@gauteh
Copy link
Contributor Author

gauteh commented Aug 15, 2023

@conda-forge-admin please rerender

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, Windows tests are passing again 🎉 @xhochy and @conda-forge/staged-recipes, this looks ready for final review and merge. Thanks @gauteh for working through the build errors!

@gauteh
Copy link
Contributor Author

gauteh commented Aug 16, 2023

Yay, Windows tests are passing again 🎉 @xhochy and @conda-forge/staged-recipes, this looks ready for final review and merge. Thanks @gauteh for working through the build errors!

Thanks. The package now runs all pytest tests, so I'm pretty confident it is working as it should.

@gauteh
Copy link
Contributor Author

gauteh commented Aug 23, 2023

Hi, any chance of pushing this through soon? Things tend to change and need to be maintained anyway, so if it is sitting too long it will require new changes and a new review.

Thanks for your time, Gaute

@gauteh
Copy link
Contributor Author

gauteh commented Sep 7, 2023

Ping, please take a look when you have time.

Regards, Gaute

@gauteh gauteh closed this Sep 30, 2023
@ocefpaf ocefpaf mentioned this pull request Oct 12, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants