Add `pyjion` #17937

dhirschfeld · 2022-02-04T11:49:55Z

Checklist

Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
License file is packaged (see here for an example).
Source is from official source.
Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
If static libraries are linked in, the license of the static library is packaged.
Build number is 0.
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
When in trouble, please check our knowledge base documentation before pinging a team.

conda-forge-linter · 2022-02-04T11:50:00Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyjion) and found some lint.

Here's what I've got...

For recipes/pyjion:

Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

conda-forge-linter · 2022-02-04T12:23:04Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyjion) and found it was in an excellent condition.

dhirschfeld · 2022-02-05T03:24:44Z

Note!

This is using a git_url as the sources aren't published on pypi and the build requires submodules to be present.

dhirschfeld · 2022-02-05T03:44:12Z

IIUC the pyjion repo builds using the dotnet submodule:

https://github.com/tonybaloney/Pyjion/blob/develop/main/.gitmodules

I'm checking with the author what that means in terms of also distributing the .NET license

License requirements for distribution tonybaloney/Pyjion#479

conda-forge-linter · 2022-02-06T11:05:34Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyjion) and found some lint.

Here's what I've got...

For recipes/pyjion:

The test section contained an unexpected subsection name. commnds is not a valid subsection name.

conda-forge-linter · 2022-02-06T11:07:21Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyjion) and found it was in an excellent condition.

dhirschfeld · 2022-02-06T11:35:15Z

It looks like CI is "passing" because all the builds are being skipped?! 🤔

Computed that there are 0 distributions to build from 1 recipes
Nothing to do

dhirschfeld · 2022-02-06T11:42:40Z

I've removed the draft status in case the solution here is to simply merge and debug in the feedstock.

Will see what the experts in @conda-forge/staged-recipes think...

recipes/pyjion/meta.yaml

dhirschfeld · 2022-02-06T14:06:57Z

It seems cmake isn't using ninja. Looks like I need to set CMAKE_MAKE_PROGRAM. That'll have to be a problem for the morning though!

  Running command Building wheel for pyjion (pyproject.toml)


  --------------------------------------------------------------------------------
  -- Trying "Unix Makefiles" generator
  --------------------------------
  ---------------------------
  ----------------------
  -----------------
  ------------
  -------
  --
  Not searching for unused variables given on the command line.
  CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
  -- Configuring incomplete, errors occurred!
  See also "/home/conda/staged-recipes/build_artifacts/pyjion_1644155830840/work/_cmake_test_compile/build/CMakeFiles/CMakeOutput.log".
  --
  -------
  ------------
  -----------------
  ----------------------
  ---------------------------
  --------------------------------
  -- Trying "Unix Makefiles" generator - failure
  --------------------------------------------------------------------------------

  ********************************************************************************
  scikit-build could not get a working generator for your system. Aborting build.
  
  × Building wheel for pyjion (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

dhirschfeld · 2022-02-06T23:22:27Z

The env var seemed to get passed through but still wasn't used:

UserWarning: The environment variable 'CMAKE_GENERATOR' is being passed through with value 'Ninja'.
If you are splitting build and test phases with --no-test, please ensure that this value is also set similarly at test time.

dhirschfeld · 2022-02-06T23:28:20Z

Odd MacOS error:

==> /Users/runner/mambaforge/bin/git describe --tags --dirty <==

1.2.6

fatal: iconv_open(UTF-8,UTF-8-MAC) failed, but needed:
    precomposed unicode is not supported.
    If you want to use decomposed unicode, run
    "git config core.precomposeunicode false"

fatal: 'git status --porcelain=2' failed in submodule CoreCLR

xref: conda-forge/git-feedstock#50 (comment)

dhirschfeld · 2022-02-07T23:58:51Z

PTAL @conda-forge/staged-recipes - I think this is good to merge!

dhirschfeld · 2022-02-08T10:27:50Z

There's a lot of top-class, whack-a-mole debugging in this PR - I'd suggest squashing & merging! 😅

recipes/pyjion/meta.yaml

dhirschfeld · 2022-02-08T11:01:15Z

Thanks @isuruf - it looks like that did the trick!

recipes/pyjion/meta.yaml

dhirschfeld · 2022-02-08T12:17:34Z

recipes/pyjion/meta.yaml

@@ -0,0 +1,79 @@
+{% set name = "pyjion" %}
+{% set version = "1.2.6" %}


The commit hash (tonybaloney/Pyjion@66a772d) could be used instead if there are concerns the tag could change?

dhirschfeld · 2022-02-08T12:22:11Z

Also, thanks for the review @chrisburr and @isuruf! I'm happy to go with the multiple sources if that's the decision - I just wanted to explain my reasoning here.

dhirschfeld · 2022-02-08T22:12:15Z

Actually tested without missing_dso_whitelist (I think I must've Ctrl-Z that change before). It fails without it so I guess I have to add it back:

ERROR (pyjion,lib/python3.10/site-packages/pyjion/_pyjion.cpython-310-x86_64-linux-gnu.so):
$RPATH/libclrjit.so not found in packages, sysroot(s) nor the missing_dso_whitelist
... is this binary repackaging?

The dotnet SDK is a binary repackage so perhaps that's why it's required here? Investigating building dotnet from source is on my TODO list.

Possibly required because `dotnet` is a binary repackage.

isuruf · 2022-02-08T22:15:09Z

The dotnet SDK is a binary repackage so perhaps that's why it's required here? Investigating building dotnet from source is on my TODO list.

No, that's because _pyjion.cpython-310-x86_64-linux-gnu.so is built without the rpath.

dhirschfeld · 2022-02-08T22:23:21Z

No, that's because _pyjion.cpython-310-x86_64-linux-gnu.so is built without the rpath.

Ok. Is there a way to fix that, or should I just keep the missing_dso_whitelist?

dhirschfeld · 2022-02-08T22:43:33Z

Ok, re-added missing_dso_whitelist. Build/tests passing. I think I've addressed all the review issues, let me know if you'd like any other changes...

dhirschfeld · 2022-02-10T07:04:49Z

ping @chrisburr, @isuruf since you're most familiar with this PR. It would be great to get this merged if you're happy with it?

recipes/pyjion/meta.yaml

Co-authored-by: Chris Burr <[email protected]>

dhirschfeld · 2022-02-10T08:21:22Z

CI passed before so I'm happy for this to be merged as the error is related to the azure outage rather than the code.
xref: conda-forge/status#125

No hosted parallelism has been purchased or granted

dhirschfeld · 2022-02-11T08:52:49Z

ping @conda-forge/staged-recipes!

Add pyjion

278bd26

lint

d99f9c8

Build for all platforms

b467384

Add tonybaloney as maintainer

a7cc965

dhirschfeld force-pushed the pyjion branch from 4c1a8fb to a7cc965 Compare February 6, 2022 03:50

Add dotnet/runtime license

b605f4b

Try enabling tests

a679435

dhirschfeld force-pushed the pyjion branch from 089ffc4 to a679435 Compare February 6, 2022 11:07

dhirschfeld marked this pull request as ready for review February 6, 2022 11:39

chrisburr reviewed Feb 6, 2022

View reviewed changes

recipes/pyjion/meta.yaml Show resolved Hide resolved

chrisburr reviewed Feb 6, 2022

View reviewed changes

recipes/pyjion/meta.yaml Show resolved Hide resolved

dhirschfeld added 6 commits February 6, 2022 23:19

Force python 3.10 (for testing)

e8bef65

Unskip (for testing)

fa4317c

Fix typo

db1560e

Disable tests

ecd5548

Change pin

41d83f8

Add cxx compiler

7101769

Add CMAKE_GENERATOR env var

5e55982

Try using CMAKE_MAKE_PROGRAM

e501f18

dhirschfeld reopened this Feb 7, 2022

isuruf reviewed Feb 8, 2022

View reviewed changes

recipes/pyjion/meta.yaml Outdated Show resolved Hide resolved

dhirschfeld added 3 commits February 8, 2022 20:42

Move dotnet to host deps

d9432fc

Link to exact commit for license file

f551622

Re-enable skip

b7e93e6

chrisburr reviewed Feb 8, 2022

View reviewed changes

recipes/pyjion/meta.yaml Outdated Show resolved Hide resolved

dhirschfeld commented Feb 8, 2022

View reviewed changes

dhirschfeld added 2 commits February 8, 2022 22:49

Use git_rev

68cf978

Re-run the tests

f1f3538

Add libclrjit.so to the missing_dso_whitelist

cc3b719

Possibly required because `dotnet` is a binary repackage.

Re-enable skip

8f44c0d

chrisburr reviewed Feb 10, 2022

View reviewed changes

recipes/pyjion/meta.yaml Outdated Show resolved Hide resolved

Update recipes/pyjion/meta.yaml

ef6be27

Co-authored-by: Chris Burr <[email protected]>

dhirschfeld closed this Feb 10, 2022

dhirschfeld reopened this Feb 10, 2022

carterbox merged commit 4d24c2a into conda-forge:main Feb 13, 2022

dhirschfeld deleted the pyjion branch February 13, 2022 02:35

This was referenced Aug 21, 2022

Create conda package giotto-ai/giotto-ph#18

Open

Add giotto-ph #20147

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `pyjion` #17937

Add `pyjion` #17937

dhirschfeld commented Feb 4, 2022 •

edited

Loading

conda-forge-linter commented Feb 4, 2022

conda-forge-linter commented Feb 4, 2022

dhirschfeld commented Feb 5, 2022

dhirschfeld commented Feb 5, 2022 •

edited

Loading

conda-forge-linter commented Feb 6, 2022

conda-forge-linter commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022 •

edited

Loading

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 7, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

isuruf commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 10, 2022

dhirschfeld commented Feb 10, 2022 •

edited

Loading

dhirschfeld commented Feb 11, 2022 •

edited

Loading

		@@ -0,0 +1,79 @@
		{% set name = "pyjion" %}
		{% set version = "1.2.6" %}

Add pyjion #17937

Add pyjion #17937

Conversation

dhirschfeld commented Feb 4, 2022 • edited Loading

conda-forge-linter commented Feb 4, 2022

conda-forge-linter commented Feb 4, 2022

dhirschfeld commented Feb 5, 2022

Note!

dhirschfeld commented Feb 5, 2022 • edited Loading

conda-forge-linter commented Feb 6, 2022

conda-forge-linter commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022 • edited Loading

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 6, 2022

dhirschfeld commented Feb 7, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld Feb 8, 2022

Choose a reason for hiding this comment

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

isuruf commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 8, 2022

dhirschfeld commented Feb 10, 2022

dhirschfeld commented Feb 10, 2022 • edited Loading

dhirschfeld commented Feb 11, 2022 • edited Loading

Add `pyjion` #17937

Add `pyjion` #17937

dhirschfeld commented Feb 4, 2022 •

edited

Loading

dhirschfeld commented Feb 5, 2022 •

edited

Loading

dhirschfeld commented Feb 6, 2022 •

edited

Loading

dhirschfeld commented Feb 10, 2022 •

edited

Loading

dhirschfeld commented Feb 11, 2022 •

edited

Loading