-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCIP optimization suite #13520
Add SCIP optimization suite #13520
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/bliss-automorphism:
Documentation on acceptable licenses can be found here. For recipes/papilo:
For recipes/papilo:
Documentation on acceptable licenses can be found here. For recipes/scip:
For recipes/scip:
Documentation on acceptable licenses can be found here. For recipes/soplex:
For recipes/soplex:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/scip:
Documentation on acceptable licenses can be found here. For recipes/soplex:
Documentation on acceptable licenses can be found here. |
@AntoinePrv This is great! With respect to static vs. shared linking:
|
@isuruf thank you for looking at this. How can I move this PR forward? |
Hey, what is the status here, can we merge this? While figuring out the future of bliss for now we want to keep the packages in this pull request as the bliss-automorphism. |
We are not going to merge this while |
That's a good point, I did not though of the headers and libraries clash when suggesting a second package. In the meantime, I still believe vendoring Bliss inside SCIP is a good way to go. This is a private dependency for SCIP, so if we |
Sure. Remember to package the license of bliss in SCIP when you do that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/scipoptsuite:
Documentation on acceptable licenses can be found here. |
@isuruf I've made some major change to the scip recipe, using the single/grouped I added the Bliss fork privately, but not test since with the |
Co-authored-by: Isuru Fernando <[email protected]>
Please add me as maintainer for scipoptsuite, pyscipopt |
Thanks a lot @isuruf ! |
Please add me as maintainer for [scipoptsuite] [pyscipopt] |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)This PR brings the SCIP optimization suite to conda-forge.
Some context:
scip
andsoplex
are package under the ZIB Academic (non commercial license) that is not listed in the SPDX License List. Perhaps a PR could be added there to add it.bliss-automorphism
is a fork, as a certain number of patches needed to be applied from the original source that seems to be unmaintained.bliss-automorphism
,soplex
,papilo
are typically build as static library. One reason for this is ease of packaging, but since dynamic libraries seem to be more appropriate for conda, I wonder if it may be worth building them as dynamic libraries. I do not know if it would negatively impact performance.