Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman #13115

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Add podman #13115

merged 4 commits into from
Nov 9, 2020

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Nov 5, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/podman) and found it was in an excellent condition.

Comment on lines 13 to 17
- 0001-Add-missing-defines-for-CentOS-6.patch
- 0002-Use-CPP-CC-and-flags-in-dep-check-scripts.patch
# NOTE: If the patch for relative paths stops working, see the buildah
# feedstock for an alternative with an hardcoded prefix path.
- 0003-Allow-relative-paths-for-system-config-files.patch
Copy link
Member Author

@mbargull mbargull Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to

  • not upstream 0001-Add-missing-defines-for-CentOS-6.patch
    IMO, we (conda-forge) should update to cos7 in the foreseeable future.
    And I don't want to burden upstream with temporarily adding these patches.
  • upstream 0002-Use-CPP-CC-and-flags-in-dep-check-scripts.patch. done in Use CPP, CC and flags in dep check scripts containers/podman#8260
  • work with upstream on how we can support the Conda use case with something less ugly than
    0003-Allow-relative-paths-for-system-config-files.patch.
    (Upstream was very forthcoming when @epruesse packaged skopeo, hence I believe we can work this out.)
    The patch works and I intend to maintain it until we have upstream support, but it's quite hacky and ideally we'd
    have something more robust that doesn't involve FallbackToPathRelativeToExe calls in random places etc.
    ref: Support for custom/relocatable install prefixes (Conda packages) containers/common#346

recipes/podman/build.sh Outdated Show resolved Hide resolved
@mbargull mbargull mentioned this pull request Nov 5, 2020
8 tasks
@mbargull mbargull requested a review from a team November 9, 2020 18:53
@ocefpaf ocefpaf merged commit 0a0eb4c into conda-forge:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants