-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podman #13115
Merged
Merged
Add podman #13115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
mbargull
commented
Nov 5, 2020
recipes/podman/meta.yaml
Outdated
Comment on lines
13
to
17
- 0001-Add-missing-defines-for-CentOS-6.patch | ||
- 0002-Use-CPP-CC-and-flags-in-dep-check-scripts.patch | ||
# NOTE: If the patch for relative paths stops working, see the buildah | ||
# feedstock for an alternative with an hardcoded prefix path. | ||
- 0003-Allow-relative-paths-for-system-config-files.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intend to
- not upstream
0001-Add-missing-defines-for-CentOS-6.patch
IMO, we (conda-forge) should update to cos7 in the foreseeable future.
And I don't want to burden upstream with temporarily adding these patches. upstreamdone in Use CPP, CC and flags in dep check scripts containers/podman#82600002-Use-CPP-CC-and-flags-in-dep-check-scripts.patch
.- work with upstream on how we can support the Conda use case with something less ugly than
0003-Allow-relative-paths-for-system-config-files.patch
.
(Upstream was very forthcoming when @epruesse packagedskopeo
, hence I believe we can work this out.)
The patch works and I intend to maintain it until we have upstream support, but it's quite hacky and ideally we'd
have something more robust that doesn't involveFallbackToPathRelativeToExe
calls in random places etc.
ref: Support for custom/relocatable install prefixes (Conda packages) containers/common#346
mbargull
commented
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)