Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for code-server #10229

Merged
merged 15 commits into from
Nov 25, 2019
Merged

Add recipe for code-server #10229

merged 15 commits into from
Nov 25, 2019

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Nov 20, 2019

Fixes #10202

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter

This comment has been minimized.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/code-server) and found some lint.

Here's what I've got...

For recipes/code-server:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/code-server) and found it was in an excellent condition.

MINIFY=true yarn build "${vscodeVersion}" "${codeServerVersion}"
yarn binary "${vscodeVersion}" "${codeServerVersion}"
mkdir -p ${PREFIX}/bin/
mv binaries/code-${VERSION}-*-x86_64 ${PREFIX}/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be code-server${VERSION}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[binary] Binary: $SRC_DIR/binaries/code-server2.1692-vsc1.39.2-darwin-x86_64
Done in 8.27s.

So it has to be code-server${VERSION} instead of code${VERSION} or code-${VERSION}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Oh, sorry. Was too early for me.

MINIFY=true yarn build "${vscodeVersion}" "${codeServerVersion}"
yarn binary "${vscodeVersion}" "${codeServerVersion}"
mkdir -p ${PREFIX}/bin/
mv binaries/code-server${VERSION}-*-x86_64 ${PREFIX}/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be mv binaries/code-server${VERSION}-*-x86_64 ${PREFIX}/bin/code-server instead, so the executable always has the name code-server, which is required for the tests.

Copy link
Member Author

@xhochy xhochy Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm sadly not able to test this locally as the recipe won't build for me on OSX due to conda-forge/git-feedstock#50 (which is not happening in CI). I therefore run the steps without conda-build and copied the necessary commands over here. The last two lines are the untested ones :(

@xhochy
Copy link
Member Author

xhochy commented Nov 21, 2019

This repackages node from a different source via https://github.com/cdr/nbin, we need to get rid of that as the binary is built on a too new system.

@xhochy xhochy marked this pull request as ready for review November 22, 2019 14:22
@xhochy
Copy link
Member Author

xhochy commented Nov 22, 2019

@conda-forge/staged-recipes This is ready for review.

@xhochy
Copy link
Member Author

xhochy commented Nov 22, 2019

This bundles VSCode inside the package but I hope that is acceptable. The VSCode installation is not separable at the current stage as it lands all in one binary.

@xhochy
Copy link
Member Author

xhochy commented Nov 25, 2019

@conda-forge/staged-recipes Please give this a a review/merge :)

@isuruf
Copy link
Member

isuruf commented Nov 25, 2019

Looks good to me, but if some packages are statically linked in the final binary, the licenses of the dependencies have to be packaged.

@xhochy
Copy link
Member Author

xhochy commented Nov 25, 2019

@isuruf Added VSCode license and third-party notices.

@isuruf isuruf merged commit c35e06d into conda-forge:master Nov 25, 2019
@xhochy xhochy deleted the code-server branch November 26, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Package code-server
4 participants