-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for code-server #10229
Add recipe for code-server #10229
Conversation
This comment has been minimized.
This comment has been minimized.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/code-server:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/code-server/build.sh
Outdated
MINIFY=true yarn build "${vscodeVersion}" "${codeServerVersion}" | ||
yarn binary "${vscodeVersion}" "${codeServerVersion}" | ||
mkdir -p ${PREFIX}/bin/ | ||
mv binaries/code-${VERSION}-*-x86_64 ${PREFIX}/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has to be code-server${VERSION}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[binary] Binary: $SRC_DIR/binaries/code-server2.1692-vsc1.39.2-darwin-x86_64
Done in 8.27s.
So it has to be code-server${VERSION}
instead of code${VERSION}
or code-${VERSION}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂ Oh, sorry. Was too early for me.
recipes/code-server/build.sh
Outdated
MINIFY=true yarn build "${vscodeVersion}" "${codeServerVersion}" | ||
yarn binary "${vscodeVersion}" "${codeServerVersion}" | ||
mkdir -p ${PREFIX}/bin/ | ||
mv binaries/code-server${VERSION}-*-x86_64 ${PREFIX}/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be mv binaries/code-server${VERSION}-*-x86_64 ${PREFIX}/bin/code-server
instead, so the executable always has the name code-server
, which is required for the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'm sadly not able to test this locally as the recipe won't build for me on OSX due to conda-forge/git-feedstock#50 (which is not happening in CI). I therefore run the steps without conda-build and copied the necessary commands over here. The last two lines are the untested ones :(
This repackages node from a different source via https://github.com/cdr/nbin, we need to get rid of that as the binary is built on a too new system. |
@conda-forge/staged-recipes This is ready for review. |
This bundles VSCode inside the package but I hope that is acceptable. The VSCode installation is not separable at the current stage as it lands all in one binary. |
@conda-forge/staged-recipes Please give this a a review/merge :) |
Co-Authored-By: Isuru Fernando <[email protected]>
Looks good to me, but if some packages are statically linked in the final binary, the licenses of the dependencies have to be packaged. |
@isuruf Added VSCode license and third-party notices. |
Fixes #10202
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)