Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recipe to v0.3.1 #2

Closed
wants to merge 11 commits into from
Closed

Conversation

orionarcher
Copy link
Contributor

@orionarcher orionarcher commented Apr 2, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@orionarcher orionarcher requested a review from hmacdope as a code owner April 2, 2023 16:41
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@orionarcher
Copy link
Contributor Author

@conda-forge-admin, please rerender

@orionarcher
Copy link
Contributor Author

orionarcher commented Apr 2, 2023

@hmacdope how does this look?

EDIT:

The build seems to be failing because it can't find the tar file at the given URL error here.

Do you have any idea why this might be happening?

@hmacdope
Copy link
Contributor

hmacdope commented Apr 2, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/solvation_analysis-feedstock/actions/runs/4591375462.

@hmacdope
Copy link
Contributor

hmacdope commented Apr 2, 2023

@orionarcher honestly no idea, the PyPi install works fine for me and re-render says no work to do. Status also says python infra is up (https://status.python.org/).

You also seem to have got the hashes right. I'll ping the cf team, I could be missing something obvious.

@hmacdope
Copy link
Contributor

hmacdope commented Apr 2, 2023

@conda-forge/help-python would you be able to provide us some guidance on this failing download in the azure CI.

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Irfan Alibay <[email protected]>
Co-authored-by: Irfan Alibay <[email protected]>
recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [30]
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@orionarcher
Copy link
Contributor Author

Thanks for taking a swing at this, the error messages mean pretty much nothing to me. Hopefully the conda-forge folks can advise.

@hmacdope
Copy link
Contributor

hmacdope commented Apr 3, 2023

Thanks for taking a swing at this, the error messages mean pretty much nothing to me. Hopefully the conda-forge folks can advise.

It's back on us now, versioneeer is misbehaving

@hmacdope
Copy link
Contributor

hmacdope commented Apr 3, 2023

I'll have another crack today

@hmacdope
Copy link
Contributor

hmacdope commented Apr 3, 2023

If i'm correct @orionarcher the issue is now that

- pathlib
- pytest
- rdkit

are not being installed as part of the pip install.

You will need to fix pyproject.toml and cut a new patch release.

@orionarcher
Copy link
Contributor Author

orionarcher commented Apr 5, 2023

Got it, thanks for the help!

I'm looking at pyproject.toml and it already includes pathlib, pytest, and rdkit. These are all available on PyPI and conda-forge and also included in requirments.txt and setup.py.

The only place they are missing is in the meta.yml in the main repo. If I update that could it fix the issue? Happy to, but don't want to mint an extra version unecessarily.

@orionarcher orionarcher closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants