Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a run for windows python 3.6 and 3.7 #39

Merged
merged 40 commits into from
Jan 8, 2019

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jan 3, 2019

Continues the work of #38 where we still need to fix the builds for python 3.7 on windows

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 3, 2019

Lets monitor on azure as well
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=3811

it might just be appveyor.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 3, 2019

@jakirkham Azure seems to be passing. What do you think about me adding the flags to make azure upload this package?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 3, 2019

@conda-forge-admin, please rerender

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 3, 2019

@jakirkham I was working on some pytorch stuff, and my rerendering might have been out of date, though the only thing I hacked in it was the fix for the azure pipelines.

Will my mods to conda-forge.yml make azure upload the packages?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 4, 2019

@conda-forge-admin, please rerender

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 4, 2019

Even azure is givimg:

2019-01-04T08:07:22.2187193Z Command "D:\bld\scikit-image_1546589029628\_h_env\python.exe -u -c "import setuptools, tokenize;__file__='C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\pip-req-build-qobvptd4\\setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record C:\Users\VSSADM~1\AppData\Local\Temp\pip-record-6wdxj55u\install-record.txt --single-version-externally-managed --compile" failed with error code 3221225477 in C:\Users\VSSADM~1\AppData\Local\Temp\pip-req-build-qobvptd4\

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 4, 2019

It seems somebody else is having issues with long paths in windows

cython/cython#2515

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dhirschfeld
Copy link
Member

Can't you just enable long-path support in Windows?
https://docs.python.org/3/using/windows.html?highlight=longpathsenabled#removing-the-max-path-limitation

In powershell you can to that with:

Set-ItemProperty -Path HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem -Name LongPathsEnabled -Value 1;

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

@mingwandroid knows that it is in the prefix mangling at the end.

but he thinks it is related to this:
https://stackoverflow.com/questions/51816639/setup-py-egg-info-error-code-3221225477

He thinks that the default prefix is about 41 characters long. so making it 50 would make it more likely.

We can try 37

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

@dhirschfeld hopefully that works

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

sorry @dhirschfeld seems like it is still happening.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

The last thing we can try is VS2017.....

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

or to make that path shorter as ray suggested.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

4/4 builds passed. I even added numpy 1.11 to the test section to confirm that it works.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

Hi @conda-forge/core,

Please move my package
scikit-image win64 builds 1000 and 1001 only
from main to broken on the conda-forge channel on anaconda.org
because on windows, pip was pulling in dependencies from pyproject.toml and building against modern versions of numpy as described in conda/conda-build#3318

It didn't seem to occur in other operating systems.

@jni
Copy link
Contributor

jni commented Jan 8, 2019

@hmaarrfk 😵🥇 🎉 🎉 🎉

@ocefpaf
Copy link
Member

ocefpaf commented Jan 8, 2019

Hi @conda-forge/core,

Please move my package
scikit-image win64 builds 1000 and 1001 only
from main to broken on the conda-forge channel on anaconda.org
because on windows, pip was pulling in dependencies from pyproject.toml and building against modern versions of numpy as described in conda/conda-build#3318

Done. Can you check if I got the right ones?

https://anaconda.org/conda-forge/scikit-image/files?version=0.14.1&channel=broken

@hmaarrfk hmaarrfk merged commit 21eca1a into conda-forge:master Jan 8, 2019
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

Thanks @ocefpaf you did. New packages should be getting built now!

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

@ocefpaf looking back, it seems that I also need 1002 on windows removed. I had back ported a fix a for numpy 1.16 on that one.

I noticed that all platforms uploaded 1004, so you can remove anything older than that really if that makes your life easier.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 8, 2019

I noticed that all platforms uploaded 1004, so you can remove anything older than that really if that makes your life easier.

Done. Please take a look and check if I got it right:

https://anaconda.org/conda-forge/scikit-image/files?version=0.14.1

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 8, 2019

I think it should be OK. From what I remember the _0 builds were OK on windows since they were using a non-problematic version of conda-build.

Thanks Felipe!!!!

@hmaarrfk hmaarrfk deleted the fix_windows_python_3.7 branch January 8, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants