Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use noarch python {{ python_min }} variable #68

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 20, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@matthewfeickert matthewfeickert self-assigned this Nov 20, 2024
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

* Use 'python {{ python_min }}' syntax for the python requirements for noarch
  python recipes.
   - c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
* Use a Jinja2 set statement for python_min to keep all the build metadata
  contained in the recipe/meta.yaml and override the global python_min
  with scikit-hep-testdata's python_min of 3.9.
* Remove --no-deps --no-build-isolation 'pip install' options in recipes as
  the build tool (e.g. conda-build, rattler-build) will enforce all required
  'pip install' options itself at build time.
* Bump build number.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11924654000.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 20, 2024 01:05
@matthewfeickert matthewfeickert requested a review from a team as a code owner November 20, 2024 01:05
@matthewfeickert matthewfeickert merged commit 79d4513 into conda-forge:main Nov 20, 2024
5 checks passed
@matthewfeickert matthewfeickert deleted the mnt/use-noarch branch November 20, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants