Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerender the feedstock to fix downstream issues #17

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Mar 11, 2024

@xhochy xhochy requested a review from pentschev as a code owner March 11, 2024 08:42
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy mentioned this pull request Mar 11, 2024
5 tasks
@xhochy
Copy link
Member Author

xhochy commented Mar 11, 2024

@conda-forge-admin please restart ci

@pentschev
Copy link
Contributor

Thanks @xhochy , if I understand correctly conda-forge/openmpi-feedstock#142 (comment) is the specific reason for this. Should we mark the previous build as broken too?

@xhochy
Copy link
Member Author

xhochy commented Mar 11, 2024

Yes, but only once we have confirmed that this build also works.

@dalcinl
Copy link

dalcinl commented Mar 11, 2024

Merge Forrest, merge!

Copy link
Contributor

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pentschev pentschev merged commit 3399b0d into conda-forge:main Mar 11, 2024
5 checks passed
@xhochy xhochy deleted the rerender branch March 11, 2024 13:27
@jakirkham
Copy link
Member

Should we mark the previous build as broken too?

Was it just one build that was broken?

@mbargull is there a good way for us to check which packages were affected?

@mbargull
Copy link
Member

Was it just one build that was broken?

See conda-forge/openmpi-feedstock#142 (comment)

@mbargull is there a good way for us to check which packages were affected?

I don't know/don't think so.

@jakirkham
Copy link
Member

Ok let's start with marking those broken

If we missed something, the errors are pretty loud. So hopefully we catch them quickly

Submitted PR: conda-forge/admin-requests#956

@h-vetinari
Copy link
Member

I don't think it's a good idea to mark these builds as broken. They're over a month old, and they only break if someone calls ldconfig (AFAIU). On top of that, while there is a functional replacement for rdma_core 50.0*=_0, there's no replacement for rdma_core 49.1, and so we're very likely to break otherwise working environments with this.

@jakirkham
Copy link
Member

We could rebuild rdma-core 49.1 too

@h-vetinari
Copy link
Member

Of course. I just didn't see the urgent need to mark them broken in the first place. That should be a measure of last resort, and aside from the build issues in openmpi, there didn't seem to be a problem AFAICT?

@jakirkham jakirkham mentioned this pull request Mar 12, 2024
5 tasks
@jakirkham
Copy link
Member

Submitting a rebuild with PR: #18

@pentschev
Copy link
Contributor

Both #18 and conda-forge/admin-requests#956 are now merged. With that I believe the issue on rdma-core front is resolved. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants