-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerender the feedstock to fix downstream issues #17
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please restart ci |
…nda-forge-pinning 2024.03.10.12.43.11
Thanks @xhochy , if I understand correctly conda-forge/openmpi-feedstock#142 (comment) is the specific reason for this. Should we mark the previous build as broken too? |
Yes, but only once we have confirmed that this build also works. |
Merge Forrest, merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Was it just one build that was broken? @mbargull is there a good way for us to check which packages were affected? |
See conda-forge/openmpi-feedstock#142 (comment)
I don't know/don't think so. |
Ok let's start with marking those broken If we missed something, the errors are pretty loud. So hopefully we catch them quickly Submitted PR: conda-forge/admin-requests#956 |
I don't think it's a good idea to mark these builds as broken. They're over a month old, and they only break if someone calls ldconfig (AFAIU). On top of that, while there is a functional replacement for rdma_core 50.0*=_0, there's no replacement for rdma_core 49.1, and so we're very likely to break otherwise working environments with this. |
We could rebuild |
Of course. I just didn't see the urgent need to mark them broken in the first place. That should be a measure of last resort, and aside from the build issues in openmpi, there didn't seem to be a problem AFAICT? |
Submitting a rebuild with PR: #18 |
Both #18 and conda-forge/admin-requests#956 are now merged. With that I believe the issue on |
As discussed in conda-forge/openmpi-feedstock#142