Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for gcc7 and so on, bump version #7

Merged
merged 6 commits into from
Jan 21, 2019

Conversation

dpryan79
Copy link
Contributor

This builds locally for Linux, not sure about the other platforms.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dpryan79
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@dpryan79
Copy link
Contributor Author

Not sure why this isn't testing on windows, I set it to not be skipped.

@dpryan79
Copy link
Contributor Author

@sodre @bgruening One of you want to take a look? The location of libjvm.so changes with openjdk releases, so I've pinned to one of them.

@bgruening
Copy link
Contributor

@dpryan79 I think the fn can be removed other than that it looks good. No clue about windows. Thanks for fixing this recipe.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dpryan79
Copy link
Contributor Author

@bgruening Thanks, I hadn't even noticed the fn, guess it was legacy. I've removed it now.

@dpryan79
Copy link
Contributor Author

@bgruening This is good to go now.

@dpryan79 dpryan79 mentioned this pull request Jan 21, 2019
@bgruening bgruening merged commit d30fa79 into conda-forge:master Jan 21, 2019
@dpryan79 dpryan79 mentioned this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants