-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing an abi3 build #41
base: main
Are you sure you want to change the base?
Conversation
…nda-forge-pinning 2024.02.02.14.47.44
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -15,23 +15,30 @@ build: | |||
script: | |||
- cargo-bundle-licenses --format yaml --output THIRDPARTY.yml | |||
- {{ PYTHON }} -m pip install . -vv | |||
ignore_run_exports_from: # [python_impl != "pypy"] | |||
- python # [python_impl != "pypy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see python >=3.10,<3.11.0a0
in the package dependencies so this didn't do what I wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaimergp Do you happen to know if it is possible to ignore the python run export? I wasn't sure if I didn't have the syntax right or if there is something special in conda build that pins the Python bounds. I tried ignore_run_exports
instead of ignore_run_exports_from
but I still see python
as a dependency bound to a single minor version. Otherwise, this approach that you outlined in conda-forge/conda-forge.github.io#1865 seems to work for me, though I need to fix the abi3audit wheel test to exclude pypy and add Windows versions of the .sh scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wow, you are trying this, nice. Honestly, I have no clue 😬 I would recommend bringing this up in the issue you mentioned, so folks interested in abi3 stuff can see the frictions we are experimenting as an ecosystem. Maybe someone has a better idea.
I wouldn't be surprised if extra work is needed in conda-build, either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, check conda-forge/python-feedstock#669 for some more context. Maybe this gets easier in the future.
I don't plan to merge this. It is a test of what an abi3 build would look like now. qiskit-terra is nearly end of life. If something like this were to be done it would be in qiskit-feedstock after qiskit 1.0. In limited testing on Linux this seems to work (can install into a conda environment with a different Python version and use qiskit without error).