Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyvo v1.0 #9

Merged
merged 5 commits into from
Sep 20, 2019
Merged

pyvo v1.0 #9

merged 5 commits into from
Sep 20, 2019

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed
  • Tests have passed
  • Updated license if changed and license_file is packaged

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@bsipocz
Copy link
Member

bsipocz commented Sep 20, 2019

Interesting. The bot didn't update the hash for the new release.
Is that a known bug @conda-forge/core ?

@isuruf
Copy link
Member

isuruf commented Sep 20, 2019

regro/cf-scripts#529

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipe:

@bsipocz
Copy link
Member

bsipocz commented Sep 20, 2019

According to conda-forge/conda-forge.github.io#556, the skip selector is all fine for python3 only packages, so I go ahead and merge this now.

@bsipocz bsipocz merged commit 29a2531 into conda-forge:master Sep 20, 2019
@isuruf
Copy link
Member

isuruf commented Sep 20, 2019

@bsipocz
Copy link
Member

bsipocz commented Sep 20, 2019

Well, tests passed and there was no clear documentation about it besides that PR (that I found through conda-forge/conda-forge.github.io#566 that I found googling for the trivial keyword combination: "how to make a noarch conda python3").

@bsipocz
Copy link
Member

bsipocz commented Sep 20, 2019

And now digging through the docs: https://conda-forge.org/docs/maintainer/knowledge_base.html?highlight=noarch#noarch-python it still says it's OK this way.

If it's not OK, then please rephrase can sometimes be replaced to be something more strict.

@isuruf
Copy link
Member

isuruf commented Sep 20, 2019

This version will be installable in python 2 as well. PRs welcome to docs

@bsipocz
Copy link
Member

bsipocz commented Sep 27, 2019

In fact this version didn't end up anywhere, as far as I see it's still the 0.9.3 that comes up as the latest.

Will try to open a PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants