-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py39 #395
Py39 #395
Conversation
…nda-forge-pinning 2020.10.06.07.41.18
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/patches/0001-Darwin-Add-arch-x86_64-to-UnicCCompiler-ld_args.patch
Outdated
Show resolved
Hide resolved
Co-authored-by: Isuru Fernando <[email protected]>
Yes, I developed a replacements thing recently just to get away from having to bash script or manually edit so much brittle stuff. Here's an example of it: https://github.com/AnacondaRecipes/qt-feedstock/blob/master/recipe/conda_build_config.yaml#L9-L28 |
recipe/meta.yaml
Outdated
@@ -221,7 +221,7 @@ outputs: | |||
- ld_impl_{{ target_platform }} # [linux] | |||
run: | |||
- ld_impl_{{ target_platform }} # [linux] | |||
- tzdata | |||
- python-tzdata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the idea was to avoid the python package and force Python to find the tzdata
noarch generic, no?
This reverts commit b2cb64a.
if os.name == 'nt': | ||
_init_non_posix(_CONFIG_VARS) | ||
- _CONFIG_VARS['TZPATH'] = '' | ||
+ _CONFIG_VARS['TZPATH'] = os.path.join(_PREFIX, "share", "zoneinfo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@mingwandroid any final thoughts/consideration? Are we good to merge? |
@mingwandroid, I removed the hand edited sysconfigdata files as they were outdated and added code to generate the sysconfigdata for the system gcc and the conda compiler. Let me know if you are okay with that. |
I say go for it (then take cover) |
Oh one quick thing: case "$target_Platform" in does the case of the P matter here? |
yes, it does. fixed in f988bc8 |
Thanks @mingwandroid and @ocefpaf |
And you @isuruf! This one really took a village to get done! |
Great to see this land. From my perspective, it's the first time I've worked on a big update to Python within conda-forge in the first instance. That's of course the best way, esp. for the important packages. It was a huge effort for many of us and of course its completion brings a whole bunch of other stuff to build, but with conda-forge's excellent tooling (and GitHub) that's not too scary a prospect. For now, I must get 3.9.0 on defaults ASAP (I added tzdata and python-tzdata already - do we need both still? I got a bit confused around that bit!). I'll base it on the recipe here, and rebase the anaconda advertising patch to happen last (this makes patch rebasing easier). On that note, we should also talk about adopting the anaconda advertising method for conda-forge too instead of the conda-forge branding stuff, it is more reliable and involves less file IO at interepreter launch time, pinging @jjhelmus on the reliability matter). CMake detects our tools now (thanks KitWare!) and will increasingly do so so having some more uniformity around this stuff would be good. Keep on keeping on conda-forge. |
To build python we only need
Sure. I don't really know what that entails but it sounds like something we could do. |
🎉
Yep, like Felipe said, it makes sense to have both.
🤘
Same here, agreed! Best thing would probably be to just open a PR whenever you're ready and discuss details there. |
You should use: .. at least until pip is rebuilt. (everyone should use this, always IMHO) |
@mingwandroid Thank you. That solved my problem. |
Ping @isuruf
Needs conda-forge/tzdata-feedstock#1
Closes #392