Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py39 #395

Merged
merged 24 commits into from
Oct 7, 2020
Merged

Py39 #395

merged 24 commits into from
Oct 7, 2020

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 6, 2020

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Isuru Fernando <[email protected]>
recipe/patches/gh21228.patch Outdated Show resolved Hide resolved
@mingwandroid
Copy link
Contributor

mingwandroid commented Oct 7, 2020

Yes, I developed a replacements thing recently just to get away from having to bash script or manually edit so much brittle stuff. Here's an example of it: https://github.com/AnacondaRecipes/qt-feedstock/blob/master/recipe/conda_build_config.yaml#L9-L28

recipe/meta.yaml Outdated
@@ -221,7 +221,7 @@ outputs:
- ld_impl_{{ target_platform }} # [linux]
run:
- ld_impl_{{ target_platform }} # [linux]
- tzdata
- python-tzdata
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the idea was to avoid the python package and force Python to find the tzdata noarch generic, no?

@jjhelmus jjhelmus mentioned this pull request Oct 7, 2020
if os.name == 'nt':
_init_non_posix(_CONFIG_VARS)
- _CONFIG_VARS['TZPATH'] = ''
+ _CONFIG_VARS['TZPATH'] = os.path.join(_PREFIX, "share", "zoneinfo")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 7, 2020

@mingwandroid any final thoughts/consideration? Are we good to merge?

@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

@mingwandroid, I removed the hand edited sysconfigdata files as they were outdated and added code to generate the sysconfigdata for the system gcc and the conda compiler. Let me know if you are okay with that.

@mingwandroid
Copy link
Contributor

I say go for it (then take cover)

@mingwandroid
Copy link
Contributor

Oh one quick thing:

case "$target_Platform" in

does the case of the P matter here?

@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

yes, it does. fixed in f988bc8

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 7, 2020

I say go for it (then take cover)

@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

Thanks @mingwandroid and @ocefpaf

@isuruf isuruf merged commit e7ea437 into conda-forge:master Oct 7, 2020
@ocefpaf ocefpaf deleted the py39 branch October 7, 2020 20:09
@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 7, 2020

And you @isuruf! This one really took a village to get done!

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 7, 2020

Also thanks to @pganssle for guiding us with the tzdata package and @mbargull for creating it!

@mingwandroid
Copy link
Contributor

mingwandroid commented Oct 8, 2020

Great to see this land. From my perspective, it's the first time I've worked on a big update to Python within conda-forge in the first instance. That's of course the best way, esp. for the important packages.

It was a huge effort for many of us and of course its completion brings a whole bunch of other stuff to build, but with conda-forge's excellent tooling (and GitHub) that's not too scary a prospect.

For now, I must get 3.9.0 on defaults ASAP (I added tzdata and python-tzdata already - do we need both still? I got a bit confused around that bit!). I'll base it on the recipe here, and rebase the anaconda advertising patch to happen last (this makes patch rebasing easier). On that note, we should also talk about adopting the anaconda advertising method for conda-forge too instead of the conda-forge branding stuff, it is more reliable and involves less file IO at interepreter launch time, pinging @jjhelmus on the reliability matter). CMake detects our tools now (thanks KitWare!) and will increasingly do so so having some more uniformity around this stuff would be good.

Keep on keeping on conda-forge.

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 8, 2020

For now, I must get 3.9.0 on defaults ASAP (I added tzdata and python-tzdata already - do we need both still?

To build python we only need tzdata. We also offer python-tzdata b/c some packages may want to use it. They do share the same zoneinfo data now.

I got a bit confused around that bit!). I'll base it on the recipe here, and rebase the anaconda advertising patch to happen last (this makes patch rebasing easier). On that note, we should also talk about adopting the anaconda advertising method for conda-forge too instead of the conda-forge branding stuff, it is more reliable and involves less file IO at interepreter launch time, pinging @jjhelmus on the reliability matter). CMake detects our tools now (thanks KitWare!) and will increasingly do so so having some more uniformity around this stuff would be good.

Sure. I don't really know what that entails but it sounds like something we could do.

@mbargull
Copy link
Member

mbargull commented Oct 8, 2020

Great to see this land. From my perspective, it's the first time I've worked on a big update to Python within conda-forge in the first instance. That's of course the best way, esp. for the important packages.

🎉

(I added tzdata and python-tzdata already - do we need both still? I got a bit confused around that bit!).

Yep, like Felipe said, it makes sense to have both. python-tzdata isn't really important for our Python distribution, because with tzdata we should ship everything zoneinfo needs. But we'll probably see (few?) other packages that may add python-tzdata as a dependency in the future.

Keep on keeping on conda-forge.

🤘


Sure. I don't really know what that entails but it sounds like something we could do.

Same here, agreed! Best thing would probably be to just open a PR whenever you're ready and discuss details there.

@Superharz
Copy link

Hello,

I'm running on a 64-Bit Windows 10 v. 1909

I just tried to install python 3.9.0 in a new empty Conda Env (named new2).
However, I always get the following error:

grafik

@mingwandroid
Copy link
Contributor

You should use: conda config --set add_pip_as_python_dependency false

.. at least until pip is rebuilt.

(everyone should use this, always IMHO)

@Superharz
Copy link

You should use: conda config --set add_pip_as_python_dependency false

.. at least until pip is rebuilt.

(everyone should use this, always IMHO)

@mingwandroid Thank you. That solved my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should we handle tzdata/zoneinfo
6 participants