Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch for 3.2.1 #117

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Update branch for 3.2.1 #117

merged 4 commits into from
Apr 15, 2022

Conversation

pkgw
Copy link

@pkgw pkgw commented Mar 18, 2022

This PR is really more of a proposal, to create a new branch for version 3.2.1 of pyproj.

As of 3.3.x, pyproj no longer supports Python 3.7. This means that the py37 packages are getting out of date with regards to evolving dependency pins, especially the bump to proj 9. For instance, sensormapgeo can't pull in the newest fontconfig on Python 3.7 because pyproj ends up sticking it with old versions of geos, gdal, etc.

I can't create a PR that proposes creating another branch, but the idea would be to turn this PR into a new branch so that the 3.2.1 builds can be rebuilt when pinnings change, at least as long as there are dependent packages that want to maintain support for Python 3.7. I revert the most recent changes to bump to the 3.3.x series, rather than forking the branch off from the last commits to support 3.2.x, to keep some of the migrations that have come in since then.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pkgw pkgw marked this pull request as draft March 18, 2022 16:35
@danschef danschef mentioned this pull request Mar 18, 2022
@snowman2
Copy link
Member

conda-forge will likely drop support for python 3.7 soon because it loosely follows the numpy deprecation policy NEP-29.

@snowman2
Copy link
Member

Is there a reason you cannot upgrade to Python 3.8?

@pkgw
Copy link
Author

pkgw commented Mar 18, 2022

There are feedstock maintainers who wish to support 3.7 for a little while longer, as best they can. I'm not familiar with the details of their use cases but I'm deferring to their judgment here. That being said, with conda-forge's policy I don't think anyone should expect anything better than best-effort support for 3.7 from here on out.

@dopplershift
Copy link
Member

I'm trying to clarify what exactly conda-forge's plans for 3.7 (and really beyond) are in conda-forge/conda-forge-pinning-feedstock#2623.

@martinfleis
Copy link

Based on the discussions linked above, it seems that Python 3.7 will stay a bit longer. I'd like to see this branch to happen as it would resolve CI failures popping up across the geopandas ecosystem testing on Python 3.7. Otherwise we would be forced to drop support for Python 3.7 on macOS as it would become complicated to create a working environment without very specific pins of dependencies of dependencies (i.e. pinning pyproj doesn't help, we would need to pin fontconfig).

@dopplershift
Copy link
Member

I just created the v3.2.1 branch, so I'd say go ahead.

@pkgw pkgw changed the base branch from main to v3.2.1 March 28, 2022 21:27
@pkgw pkgw marked this pull request as ready for review March 28, 2022 21:27
@pkgw pkgw changed the title DO NOT MERGE: Proposal: create branch for 3.2.1 Update branch for 3.2.1 Mar 28, 2022
@pkgw
Copy link
Author

pkgw commented Mar 28, 2022

Thanks! I've updated this PR to target the 3.2.1 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants