Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipped test for pymc package #42

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jun 6, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@maresb
Copy link
Contributor Author

maresb commented Jun 6, 2022

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits June 6, 2022 12:41
@maresb
Copy link
Contributor Author

maresb commented Jun 6, 2022

Windows is failing due to conda-forge/aesara-feedstock#54, in particular

WARN: Could not locate executable g77
WARN: Could not locate executable f77
WARN: Could not locate executable ifort
WARN: Could not locate executable ifl
WARN: Could not locate executable f90
WARN: Could not locate executable efl

It's not 100% the same, since DF isn't missing here, but it is in the original report.

@maresb
Copy link
Contributor Author

maresb commented Jun 6, 2022

Excellent, this is now failing correctly! 😄

The hunt for a solution continues upstream in conda-forge/aesara-feedstock#68

@maresb
Copy link
Contributor Author

maresb commented Jun 6, 2022

Ok, I believe this is now ready to merge! 🎉

Since the previous merge of #41 into main there are no changes which would affect the package (no dependency changes). Therefore, it should be fine to merge this with the build number 1 since creating build 2 would be pointless.

On Windows, we still see the Could not locate executable warnings, but they are safe to ignore. (Hopefully they can be fixed soon.)

I do think that it would be worthwhile considering #40. Otherwise, the solver will always consider the premature build 0 where mkl-service (or openblas in the case of M1) is missing from the requirements. In particular, if some conflict prevents mkl-service from being installed, then the solver will choose build 0, and we no longer can assume that pymc >=4.0.0 will include mkl-service.

@maresb maresb marked this pull request as ready for review June 6, 2022 21:19
@twiecki twiecki merged commit 34ee720 into conda-forge:main Jun 6, 2022
@twiecki
Copy link
Contributor

twiecki commented Jun 6, 2022

Thanks @maresb!

@maresb
Copy link
Contributor Author

maresb commented Jun 6, 2022

Thanks @twiecki for the quick merge! 😄

@maresb maresb deleted the fix-pymc-test branch June 6, 2022 21:28
@maresb maresb mentioned this pull request Jun 6, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants