Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CFEP-25 noarch: python syntax #46

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR updates the recipe to use the noarch: python syntax as described in CFEP-25. Please see our documentation for more details.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12448949273 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mikofski
Copy link
Member

@kandersolar should we add (at)bot-automerge?

@mikofski
Copy link
Member

@kandersolar this PR seems fine to merge, all it does is create a variable, python-min that replaces 3.9 everywhere, as pvlib’s min Python version was already pinned and therefore complying with CFEP-25

@kandersolar
Copy link
Member

It seems that the variable is defined globally for all of conda-forge: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml#L846-L849

So by merging this PR the way it is now, we would be giving up all control of our minimum supported python. I don't think that's desirable. What if pvlib drops support for python 3.9 before conda-forge does?

I think what we actually want here is something like maximum(conda_forge_minimum, our_own_minimum). That way we can drop versions before conda-forge does, and if conda-forge drops support first, we don't have a broken build recipe. Not sure how to encode that in a conda-forge recipe though... will need to check out the docs.

@ocefpaf ocefpaf added the automerge Merge the PR when CI passes label Jan 7, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@kandersolar
Copy link
Member

@ocefpaf can you please remove the automerge label? See my comment above about not necessarily wanting to merge this PR as-is.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 7, 2025

So by merging this PR the way it is now, we would be giving up all control of our minimum supported python. I don't think that's desirable. What if pvlib drops support for python 3.9 before conda-forge does?

Please read CFEP-25 and the documentation attached in the original bot message:

https://github.com/conda-forge/cfep/blob/main/cfep-25.md
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

@kandersolar kandersolar removed the automerge Merge the PR when CI passes label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants