Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry v1.3.0 #77

Merged
merged 10 commits into from
Dec 11, 2022
Merged

poetry v1.3.0 #77

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7609c3e
updated v1.3.0
regro-cf-autotick-bot Dec 10, 2022
56edea6
MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…
regro-cf-autotick-bot Dec 10, 2022
a21c81e
Update dependencies and drop noarch:python
xylar Dec 10, 2022
e0396e6
Fix typo
xylar Dec 10, 2022
169bab5
MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…
Dec 10, 2022
d312cf1
Fix virtualenv
xylar Dec 10, 2022
fd34da2
explain xattr
xylar Dec 11, 2022
59e2ce8
Add lockfile dependency
xylar Dec 11, 2022
6110546
Fix darwin-->osx (hopefully)
xylar Dec 11, 2022
0c177e0
Readd requirements.build with cross-python
maresb Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ requirements:
- poetry-plugin-export >=1.2.0,<2.0.0
- backports.cached-property >=1.0.2,<2.0.0 # [py<38]
- cachecontrol >=0.12.9,<0.13.0

# cachecontrol filecache extra
- filelock >=3.8.0

Expand Down Expand Up @@ -56,6 +56,9 @@ requirements:
- xattr >=0.10.0,<0.11.0 # [darwin]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one I see no way around -- we can't be noarch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does installing xattr break non-osx?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, xattr doesn't exist for win:
https://github.com/conda-forge/xattr-feedstock/blob/main/recipe/meta.yaml#L16

And I would hesitate to override the upstream choices in general to too great a degree.

xylar marked this conversation as resolved.
Show resolved Hide resolved
- urllib3 >=1.26.0,<2.0.0

# `poetry` entry point fails without this:
- lockfile >=0.9
Comment on lines +62 to +63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is necessary, but I'm confused how Poetry works when this isn't an explicit dependency. Do you understand where it's coming from? Maybe there is a missing dependency from filelock or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reported this upstream in python-poetry/poetry#7171. Let's see what they say.

I also think it's a problem regardless of whether this should come from another dependency because it's an explicit dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, explicit dependencies should definitely be included by the package using them. But it's probably also an implicit dependency which is missing somewhere on CF... I can try to have a look...


test:
requires:
- pip
Expand Down