Remove setuptools, wheel deps for python>=3.13 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
requested review from
jakirkham,
mingwandroid,
msarahan,
ocefpaf and
pelson
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
beckermr
approved these changes
Aug 28, 2024
beckermr
reviewed
Aug 28, 2024
beckermr
reviewed
Aug 28, 2024
h-vetinari
approved these changes
Aug 29, 2024
h-vetinari
reviewed
Aug 29, 2024
recipe/meta.yaml
Outdated
| disable_pip: true | ||
| entry_points: | ||
| - pip = pip._internal.cli.main:main | ||
| - pip3 = pip._internal.cli.main:main | ||
|
|
||
| requirements: | ||
| host: | ||
| - python >=3.8 | ||
| - python >=3.13.a0 # [not with_setuptools_wheel] |
There was a problem hiding this comment.
Not 100% sure about the dot before a0 and missing patch version; in any case, we only have rc1 builds, so I think this could be
Suggested change
| - python >=3.13.a0 # [not with_setuptools_wheel] | |
| - python >=3.13.0rc1 # [not with_setuptools_wheel] |
h-vetinari
reviewed
Aug 29, 2024
recipe/meta.yaml
Outdated
| disable_pip: true | ||
| entry_points: | ||
| - pip = pip._internal.cli.main:main | ||
| - pip3 = pip._internal.cli.main:main | ||
|
|
||
| requirements: | ||
| host: | ||
| - python >=3.8 | ||
| - python >=3.13.a0 # [not with_setuptools_wheel] | ||
| - python >=3.8,<3.13.a0 # [with_setuptools_wheel] |
There was a problem hiding this comment.
Suggested change
| - python >=3.8,<3.13.a0 # [with_setuptools_wheel] | |
| - python >=3.8,<3.13.0a0 # [with_setuptools_wheel] |
|
@conda-forge/pip, this is ready |
7 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)